test: add test cases in ContractsByCode #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
170210
requested review from
da1suk8,
dudong2,
loloicci and
Kynea0b
as code owners
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
170210
force-pushed
the
fixup/contractsByCode
branch
from
45127a2 to
4ba65f0
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 62.74% 62.80% +0.06%
==========================================
Files 80 80
Lines 9966 9966
==========================================
+ Hits 6253 6259 +6
+ Misses 3383 3379 -4
+ Partials 330 328 -2 |
Kynea0b
previously approved these changes
Aug 15, 2023
|
I think it's okay to delete unnecessary items in the explanation of the PR template. |
da1suk8
previously approved these changes
Aug 16, 2023
5 tasks
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
da1suk8
reviewed
Aug 18, 2023
da1suk8
approved these changes
Aug 18, 2023
loloicci
approved these changes
Aug 18, 2023
5 tasks
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test cases in function ContractsByCode because we have not tested it.
This PR adds 8 test cases to this function, including #65 and #66.
How has this been tested?
Unit tests
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml(not need)