Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add clarifications to the order of list response in query #103

Merged
merged 6 commits into from
Aug 25, 2023
Merged

docs: add clarifications to the order of list response in query #103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
af9b259
docs: add clarification to the order of list response in query
170210 Aug 25, 2023
af96b8f
chore: make proto-gen and format
170210 Aug 25, 2023
72a9a47
chore: add this pr to CHANGELOG
170210 Aug 25, 2023
32258b3
fixup: fix for comment
170210 Aug 25, 2023
9f96275
fixup: merge main
170210 Aug 25, 2023
19c61d4
fixup: fix for comment
170210 Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/proto/proto-docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1081,7 +1081,7 @@ Query/ContractHistory RPC method

| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| `entries` | [ContractCodeHistoryEntry](#cosmwasm.wasm.v1.ContractCodeHistoryEntry) | repeated | return in the order of contract execution |
| `entries` | [ContractCodeHistoryEntry](#cosmwasm.wasm.v1.ContractCodeHistoryEntry) | repeated | return in the order of timestamps according to contract updates |
| `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response. |


Expand Down Expand Up @@ -1148,7 +1148,7 @@ Query/ContractsByCode RPC method

| Field | Type | Label | Description |
| ----- | ---- | ----- | ----------- |
| `contracts` | [string](#string) | repeated | contracts are a set of contract addresses return in the order of instantiation |
| `contracts` | [string](#string) | repeated | contracts are a set of contract addresses. return in the order of timestamps according to instantiation or migration |
| `pagination` | [cosmos.base.query.v1beta1.PageResponse](#cosmos.base.query.v1beta1.PageResponse) | | pagination defines the pagination in the response. |


Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ require (
github.com/Finschia/finschia-sdk v0.48.0-rc1
github.com/Finschia/ostracon v1.1.1
github.com/Finschia/wasmvm v1.1.1-0.11.2.0.20230418093236-ce70a3856778
github.com/cosmos/btcutil v1.0.5
github.com/cosmos/iavl v0.19.4
github.com/cosmos/ibc-go/v4 v4.3.1
github.com/dvsekhvalnov/jose2go v1.5.0
Expand Down Expand Up @@ -51,7 +52,6 @@ require (
github.com/coinbase/rosetta-sdk-go v0.8.3 // indirect
github.com/coinbase/rosetta-sdk-go/types v1.0.0 // indirect
github.com/confio/ics23/go v0.9.0 // indirect
github.com/cosmos/btcutil v1.0.5 // indirect
github.com/cosmos/go-bip39 v1.0.0 // indirect
github.com/cosmos/gorocksdb v1.2.0 // indirect
github.com/cosmos/ledger-cosmos-go v0.12.2 // indirect
Expand Down
6 changes: 3 additions & 3 deletions proto/cosmwasm/wasm/v1/query.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ message QueryContractHistoryRequest {
// QueryContractHistoryResponse is the response type for the
// Query/ContractHistory RPC method
message QueryContractHistoryResponse {
// return in the order of contract execution
// return in the order of timestamps according to contract updates
loloicci marked this conversation as resolved.
Show resolved Hide resolved
repeated ContractCodeHistoryEntry entries = 1
[ (gogoproto.nullable) = false ];
// pagination defines the pagination in the response.
Expand All @@ -115,8 +115,8 @@ message QueryContractsByCodeRequest {
// QueryContractsByCodeResponse is the response type for the
// Query/ContractsByCode RPC method
message QueryContractsByCodeResponse {
// contracts are a set of contract addresses
// return in the order of instantiation
// contracts are a set of contract addresses.
// return in the order of timestamps according to instantiation or migration
repeated string contracts = 1;

// pagination defines the pagination in the response.
Expand Down
6 changes: 3 additions & 3 deletions x/wasm/types/query.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.