Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add clarifications to the order of list response in query #103

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

170210
Copy link

@170210 170210 commented Aug 25, 2023

Description

This PR adds clarifications to the order of list response in x/wasm query, which will make it easier for developers to understand the returned order.
closes: #91

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.(not need)
  • I have updated the documentation accordingly.(not need)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml(not need)

@170210 170210 requested a review from zemyblue August 25, 2023 04:55
@170210 170210 self-assigned this Aug 25, 2023
@170210 170210 changed the title Docs/add des docs: add clarification to the order of list response in query Aug 25, 2023
@170210 170210 changed the title docs: add clarification to the order of list response in query docs: add description to the order of list response in query Aug 25, 2023
@170210 170210 changed the title docs: add description to the order of list response in query docs: add clarifications to the order of list response in query Aug 25, 2023
@170210 170210 marked this pull request as ready for review August 25, 2023 04:59
@170210 170210 marked this pull request as draft August 25, 2023 05:03
@170210 170210 marked this pull request as ready for review August 25, 2023 05:19
docs/proto/proto-docs.md Outdated Show resolved Hide resolved
docs/proto/proto-docs.md Outdated Show resolved Hide resolved
170210 added 2 commits August 25, 2023 18:01
Signed-off-by: 170210 <[email protected]>
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #103 (9f96275) into main (9b19afb) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   63.62%   63.65%   +0.02%     
==========================================
  Files          80       80              
  Lines       10001    10001              
==========================================
+ Hits         6363     6366       +3     
+ Misses       3308     3306       -2     
+ Partials      330      329       -1     

see 1 file with indirect coverage changes

@170210 170210 merged commit 9dbd83e into Finschia:main Aug 25, 2023
@zemyblue zemyblue mentioned this pull request Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write comments to querier how pagination sorts infos
3 participants