forked from CosmWasm/wasmd
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add clarifications to the order of list response in query #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
170210
changed the title
Docs/add des
docs: add clarification to the order of list response in query
Aug 25, 2023
170210
changed the title
docs: add clarification to the order of list response in query
docs: add description to the order of list response in query
Aug 25, 2023
170210
changed the title
docs: add description to the order of list response in query
docs: add clarifications to the order of list response in query
Aug 25, 2023
170210
requested review from
da1suk8,
dudong2,
loloicci and
Kynea0b
as code owners
August 25, 2023 04:59
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
loloicci
reviewed
Aug 25, 2023
Signed-off-by: 170210 <[email protected]>
Signed-off-by: 170210 <[email protected]>
loloicci
reviewed
Aug 25, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #103 +/- ##
==========================================
+ Coverage 63.62% 63.65% +0.02%
==========================================
Files 80 80
Lines 10001 10001
==========================================
+ Hits 6363 6366 +3
+ Misses 3308 3306 -2
+ Partials 330 329 -1 |
Signed-off-by: 170210 <[email protected]>
loloicci
approved these changes
Aug 25, 2023
da1suk8
approved these changes
Aug 25, 2023
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds clarifications to the order of list response in x/wasm query, which will make it easier for developers to understand the returned order.
closes: #91
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml
(not need)