Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the constant maxPerPage configurable. #309

Open
4 tasks
egonspace opened this issue Aug 25, 2021 · 1 comment
Open
4 tasks

Make the constant maxPerPage configurable. #309

egonspace opened this issue Aug 25, 2021 · 1 comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code D: good first issue Decision: Good for newcomers P: nice to have Priority: nice to have Stale For github bot

Comments

@egonspace
Copy link
Contributor

Summary

The constant maxPerPage of rpc/core/env.go is hard-coded currently. But it's better to change this value to be configurable.

maxPerPage = 10000

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@egonspace egonspace mentioned this issue Aug 25, 2021
Merged
@torao torao added C: enhancement Classification: New feature or its request, or improvement in maintainability of code D: good first issue Decision: Good for newcomers P: nice to have Priority: nice to have labels Sep 29, 2021
@github-actions github-actions bot added the Stale For github bot label Feb 26, 2022
@github-actions github-actions bot closed this as completed Mar 2, 2022
@torao
Copy link
Contributor

torao commented Mar 7, 2022

(accidentally closed by bot😱)

@torao torao reopened this Mar 8, 2022
@github-actions github-actions bot removed the Stale For github bot label Mar 9, 2022
@github-actions github-actions bot added the Stale For github bot label Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code D: good first issue Decision: Good for newcomers P: nice to have Priority: nice to have Stale For github bot
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@torao @egonspace