From d9393849034808c25a18e3aef679e10cf464b3bd Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Wed, 9 Nov 2022 06:43:00 +0000 Subject: [PATCH 1/4] Use snake_case field name --- docs/core/proto-docs.md | 2 +- proto/lbm/foundation/v1/genesis.proto | 4 +- x/foundation/genesis.pb.go | 69 ++++++++++++++------------- 3 files changed, 38 insertions(+), 37 deletions(-) diff --git a/docs/core/proto-docs.md b/docs/core/proto-docs.md index bd794d9e06..b9cb6704d6 100644 --- a/docs/core/proto-docs.md +++ b/docs/core/proto-docs.md @@ -17299,7 +17299,7 @@ GenesisState defines the foundation module's genesis state. | `votes` | [Vote](#lbm.foundation.v1.Vote) | repeated | votes is the list of votes. | | `authorizations` | [GrantAuthorization](#lbm.foundation.v1.GrantAuthorization) | repeated | grants | | `pool` | [Pool](#lbm.foundation.v1.Pool) | | pool | -| `govMintLeftCount` | [uint32](#uint32) | | govMintLeftCount is gov mint max count | +| `gov_mint_left_count` | [uint32](#uint32) | | gov_mint_count_left is the remaining number of times for gov_mint. | diff --git a/proto/lbm/foundation/v1/genesis.proto b/proto/lbm/foundation/v1/genesis.proto index 6ca6a56839..fed433a0be 100644 --- a/proto/lbm/foundation/v1/genesis.proto +++ b/proto/lbm/foundation/v1/genesis.proto @@ -38,8 +38,8 @@ message GenesisState { // pool Pool pool = 8 [(gogoproto.nullable) = false]; - // govMintLeftCount is gov mint max count - uint32 govMintLeftCount = 9; + // gov_mint_count_left is the remaining number of times for gov_mint. + uint32 gov_mint_left_count = 9; } // GrantAuthorization defines authorization grant to grantee via route. diff --git a/x/foundation/genesis.pb.go b/x/foundation/genesis.pb.go index 5c6af26a13..ab8a10d919 100644 --- a/x/foundation/genesis.pb.go +++ b/x/foundation/genesis.pb.go @@ -43,8 +43,8 @@ type GenesisState struct { Authorizations []GrantAuthorization `protobuf:"bytes,7,rep,name=authorizations,proto3" json:"authorizations"` // pool Pool Pool `protobuf:"bytes,8,opt,name=pool,proto3" json:"pool"` - // govMintLeftCount is gov mint max count - GovMintLeftCount uint32 `protobuf:"varint,9,opt,name=govMintLeftCount,proto3" json:"govMintLeftCount,omitempty"` + // gov_mint_count_left is the remaining number of times for gov_mint. + GovMintLeftCount uint32 `protobuf:"varint,9,opt,name=gov_mint_left_count,json=govMintLeftCount,proto3" json:"gov_mint_left_count,omitempty"` } func (m *GenesisState) Reset() { *m = GenesisState{} } @@ -127,39 +127,40 @@ func init() { func init() { proto.RegisterFile("lbm/foundation/v1/genesis.proto", fileDescriptor_c5e13dd78b24d473) } var fileDescriptor_c5e13dd78b24d473 = []byte{ - // 505 bytes of a gzipped FileDescriptorProto + // 516 bytes of a gzipped FileDescriptorProto 0x1f, 0x8b, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00, 0x02, 0xff, 0x8c, 0x92, 0x51, 0x6b, 0xd3, 0x50, - 0x14, 0xc7, 0x13, 0x97, 0xb5, 0xeb, 0xd5, 0x89, 0x5e, 0x0a, 0xde, 0x4d, 0x48, 0x6b, 0x51, 0x28, - 0xc2, 0x72, 0xed, 0x06, 0x8a, 0x7b, 0x91, 0x55, 0xb0, 0x0c, 0x1c, 0x94, 0x0c, 0x7c, 0xf0, 0x65, - 0x24, 0xeb, 0x6d, 0x16, 0x4c, 0xee, 0x09, 0xb9, 0x37, 0xc1, 0xf9, 0x09, 0x7c, 0xf4, 0x23, 0xec, - 0x71, 0xaf, 0x82, 0x1f, 0x62, 0xf8, 0xb4, 0x47, 0x9f, 0x44, 0xda, 0x17, 0x3f, 0x86, 0xf4, 0xe6, - 0xc6, 0xb6, 0x36, 0xc2, 0xde, 0x72, 0x72, 0x7e, 0xbf, 0x73, 0xfe, 0x09, 0x07, 0xb5, 0x22, 0x3f, - 0xa6, 0x63, 0xc8, 0xf8, 0xc8, 0x93, 0x21, 0x70, 0x9a, 0xf7, 0x68, 0xc0, 0x38, 0x13, 0xa1, 0x70, - 0x92, 0x14, 0x24, 0xe0, 0xfb, 0x91, 0x1f, 0x3b, 0x73, 0xc0, 0xc9, 0x7b, 0xdb, 0xcd, 0x00, 0x02, - 0x50, 0x5d, 0x3a, 0x7b, 0x2a, 0xc0, 0xed, 0xce, 0xea, 0xa4, 0x05, 0xad, 0x60, 0xb6, 0x4e, 0x41, - 0xc4, 0x20, 0x4e, 0x0a, 0xb9, 0x28, 0xca, 0x56, 0x00, 0x10, 0x44, 0x8c, 0xaa, 0xca, 0xcf, 0xc6, - 0xd4, 0xe3, 0xe7, 0x45, 0xab, 0xf3, 0xd5, 0x42, 0x77, 0x06, 0x45, 0xa8, 0x63, 0xe9, 0x49, 0x86, - 0x5f, 0xa0, 0x5a, 0xe2, 0xa5, 0x5e, 0x2c, 0x88, 0xd9, 0x36, 0xbb, 0xb7, 0x77, 0xb7, 0x9c, 0x95, - 0x90, 0xce, 0x50, 0x01, 0x7d, 0xeb, 0xea, 0x67, 0xcb, 0x70, 0x35, 0x8e, 0x07, 0x08, 0xcd, 0x29, - 0x72, 0x4b, 0xc9, 0x8f, 0x2a, 0xe4, 0x37, 0x7f, 0xab, 0x43, 0x3e, 0x06, 0x3d, 0x64, 0x41, 0xc5, - 0x2f, 0x51, 0x3d, 0x66, 0xb1, 0xcf, 0x52, 0x41, 0xd6, 0xda, 0x6b, 0xff, 0x89, 0x70, 0xa4, 0x08, - 0x6d, 0x97, 0x3c, 0x7e, 0x86, 0x9a, 0x49, 0xca, 0xf2, 0x10, 0x32, 0xf5, 0x1f, 0x12, 0x10, 0x5e, - 0x74, 0x12, 0x8e, 0x88, 0xd5, 0x36, 0xbb, 0x96, 0x8b, 0xcb, 0xde, 0x50, 0xb7, 0x0e, 0x47, 0xf8, - 0x15, 0x6a, 0x94, 0xa0, 0x20, 0xeb, 0x6a, 0xdd, 0xc3, 0xaa, 0x2f, 0xd6, 0x8c, 0x5e, 0x38, 0x77, - 0xf0, 0x1e, 0x5a, 0xcf, 0x41, 0x32, 0x41, 0x6a, 0x4a, 0x7e, 0x50, 0x21, 0xbf, 0x03, 0xc9, 0xb4, - 0x58, 0xb0, 0xf8, 0x18, 0xdd, 0xf5, 0x32, 0x79, 0x06, 0x69, 0xf8, 0x49, 0x51, 0x82, 0xd4, 0x95, - 0xfd, 0xa4, 0xc2, 0x1e, 0xa4, 0x1e, 0x97, 0x07, 0x8b, 0xb4, 0x9e, 0xf5, 0xcf, 0x08, 0xdc, 0x43, - 0x56, 0x02, 0x10, 0x91, 0x0d, 0xf5, 0xeb, 0xab, 0x82, 0x0c, 0x01, 0xca, 0x2f, 0x50, 0x28, 0x7e, - 0x8a, 0xee, 0x05, 0x90, 0x1f, 0x85, 0x5c, 0xbe, 0x65, 0x63, 0xf9, 0x1a, 0x32, 0x2e, 0x49, 0xa3, - 0x6d, 0x76, 0x37, 0xdd, 0x95, 0xf7, 0xfb, 0x1b, 0x9f, 0x2f, 0x5a, 0xc6, 0xef, 0x8b, 0x96, 0xd1, - 0xb9, 0x34, 0x11, 0x5e, 0x4d, 0x85, 0x09, 0xaa, 0x07, 0xb3, 0xb7, 0x8c, 0xa9, 0xd3, 0x69, 0xb8, - 0x65, 0x89, 0x53, 0xb4, 0xb9, 0x94, 0x55, 0x5f, 0x47, 0xd3, 0x29, 0xee, 0xd2, 0x29, 0xef, 0xd2, - 0x39, 0xe0, 0xe7, 0xfd, 0xe7, 0xdf, 0xbf, 0xed, 0xec, 0x06, 0xa1, 0x3c, 0xcb, 0x7c, 0xe7, 0x14, - 0x62, 0x1a, 0x85, 0x9c, 0xd1, 0xc8, 0x8f, 0x77, 0xc4, 0xe8, 0x03, 0xfd, 0xb8, 0x78, 0xf7, 0x4b, - 0xeb, 0xdd, 0xe5, 0x15, 0xfb, 0xd6, 0x2c, 0x6e, 0xbf, 0x7f, 0x39, 0xb1, 0xcd, 0xab, 0x89, 0x6d, - 0x5e, 0x4f, 0x6c, 0xf3, 0xd7, 0xc4, 0x36, 0xbf, 0x4c, 0x6d, 0xe3, 0x7a, 0x6a, 0x1b, 0x3f, 0xa6, - 0xb6, 0xf1, 0xfe, 0xf1, 0x4d, 0xd6, 0xf8, 0x35, 0x15, 0x6f, 0xef, 0x4f, 0x00, 0x00, 0x00, 0xff, - 0xff, 0x65, 0x6c, 0xa2, 0xd8, 0xcf, 0x03, 0x00, 0x00, + 0x14, 0xc7, 0x13, 0x97, 0xb5, 0xeb, 0xd5, 0x89, 0x5e, 0x0b, 0xde, 0x4d, 0x48, 0x6b, 0x51, 0xe8, + 0x4b, 0x13, 0xbb, 0x81, 0xe2, 0x5e, 0x64, 0x15, 0x2c, 0x03, 0x07, 0x25, 0x03, 0x1f, 0x7c, 0x09, + 0x49, 0x7b, 0x93, 0x05, 0x93, 0x7b, 0x42, 0xee, 0x4d, 0x70, 0x7e, 0x02, 0x1f, 0xfd, 0x08, 0x7b, + 0xdc, 0x07, 0xd8, 0x87, 0x18, 0x3e, 0xf5, 0xd1, 0x27, 0x91, 0xf6, 0xc5, 0x8f, 0x21, 0xbd, 0x49, + 0x6c, 0x6b, 0x23, 0xec, 0x2d, 0x27, 0xe7, 0xf7, 0x3b, 0xe7, 0x9f, 0x70, 0x50, 0x2b, 0x74, 0x23, + 0xd3, 0x83, 0x94, 0x4d, 0x1c, 0x11, 0x00, 0x33, 0xb3, 0xbe, 0xe9, 0x53, 0x46, 0x79, 0xc0, 0x8d, + 0x38, 0x01, 0x01, 0xf8, 0x61, 0xe8, 0x46, 0xc6, 0x12, 0x30, 0xb2, 0xfe, 0x7e, 0xd3, 0x07, 0x1f, + 0x64, 0xd7, 0x5c, 0x3c, 0xe5, 0xe0, 0x7e, 0x67, 0x73, 0xd2, 0x8a, 0x96, 0x33, 0x7b, 0x63, 0xe0, + 0x11, 0x70, 0x3b, 0x97, 0xf3, 0xa2, 0x6c, 0xf9, 0x00, 0x7e, 0x48, 0x4d, 0x59, 0xb9, 0xa9, 0x67, + 0x3a, 0xec, 0x22, 0x6f, 0x75, 0xae, 0x35, 0x74, 0x6f, 0x98, 0x87, 0x3a, 0x13, 0x8e, 0xa0, 0xf8, + 0x15, 0xaa, 0xc5, 0x4e, 0xe2, 0x44, 0x9c, 0xa8, 0x6d, 0xb5, 0x7b, 0xf7, 0x60, 0xcf, 0xd8, 0x08, + 0x69, 0x8c, 0x24, 0x30, 0xd0, 0x6e, 0x7e, 0xb6, 0x14, 0xab, 0xc0, 0xf1, 0x10, 0xa1, 0x25, 0x45, + 0xee, 0x48, 0xf9, 0x69, 0x85, 0xfc, 0xee, 0x6f, 0x75, 0xc2, 0x3c, 0x28, 0x86, 0xac, 0xa8, 0xf8, + 0x35, 0xaa, 0x47, 0x34, 0x72, 0x69, 0xc2, 0xc9, 0x56, 0x7b, 0xeb, 0x3f, 0x11, 0x4e, 0x25, 0x51, + 0xd8, 0x25, 0x8f, 0x5f, 0xa0, 0x66, 0x9c, 0xd0, 0x2c, 0x80, 0x54, 0xfe, 0x87, 0x18, 0xb8, 0x13, + 0xda, 0xc1, 0x84, 0x68, 0x6d, 0xb5, 0xab, 0x59, 0xb8, 0xec, 0x8d, 0x8a, 0xd6, 0xc9, 0x04, 0xbf, + 0x41, 0x8d, 0x12, 0xe4, 0x64, 0x5b, 0xae, 0x7b, 0x52, 0xf5, 0xc5, 0x05, 0x53, 0x2c, 0x5c, 0x3a, + 0xf8, 0x10, 0x6d, 0x67, 0x20, 0x28, 0x27, 0x35, 0x29, 0x3f, 0xae, 0x90, 0x3f, 0x80, 0xa0, 0x85, + 0x98, 0xb3, 0xf8, 0x0c, 0xdd, 0x77, 0x52, 0x71, 0x0e, 0x49, 0xf0, 0x45, 0x52, 0x9c, 0xd4, 0xa5, + 0xfd, 0xbc, 0xc2, 0x1e, 0x26, 0x0e, 0x13, 0xc7, 0xab, 0x74, 0x31, 0xeb, 0x9f, 0x11, 0xb8, 0x8f, + 0xb4, 0x18, 0x20, 0x24, 0x3b, 0xf2, 0xd7, 0x57, 0x05, 0x19, 0x01, 0x94, 0x5f, 0x20, 0x51, 0xdc, + 0x43, 0x8f, 0x7c, 0xc8, 0xec, 0x28, 0x60, 0xc2, 0x0e, 0xa9, 0x27, 0xec, 0x31, 0xa4, 0x4c, 0x90, + 0x46, 0x5b, 0xed, 0xee, 0x5a, 0x0f, 0x7c, 0xc8, 0x4e, 0x03, 0x26, 0xde, 0x53, 0x4f, 0xbc, 0x5d, + 0xbc, 0x3f, 0xda, 0xf9, 0x7a, 0xd9, 0x52, 0x7e, 0x5f, 0xb6, 0x94, 0xce, 0x95, 0x8a, 0xf0, 0x66, + 0x30, 0x4c, 0x50, 0xdd, 0x5f, 0xbc, 0xa5, 0x54, 0x5e, 0x4f, 0xc3, 0x2a, 0x4b, 0x9c, 0xa0, 0xdd, + 0xb5, 0xb8, 0xc5, 0x81, 0x34, 0x8d, 0xfc, 0x34, 0x8d, 0xf2, 0x34, 0x8d, 0x63, 0x76, 0x31, 0x78, + 0xf9, 0xfd, 0xba, 0x77, 0xe0, 0x07, 0xe2, 0x3c, 0x75, 0x8d, 0x31, 0x44, 0x66, 0x18, 0x30, 0x6a, + 0x86, 0x6e, 0xd4, 0xe3, 0x93, 0x4f, 0xe6, 0xe7, 0xd5, 0xd3, 0x5f, 0x5b, 0x6f, 0xad, 0xaf, 0x38, + 0xd2, 0x16, 0x71, 0x07, 0x83, 0xab, 0x99, 0xae, 0xde, 0xcc, 0x74, 0x75, 0x3a, 0xd3, 0xd5, 0x5f, + 0x33, 0x5d, 0xfd, 0x36, 0xd7, 0x95, 0xe9, 0x5c, 0x57, 0x7e, 0xcc, 0x75, 0xe5, 0xe3, 0xb3, 0xdb, + 0xac, 0x71, 0x6b, 0x32, 0xde, 0xe1, 0x9f, 0x00, 0x00, 0x00, 0xff, 0xff, 0xc6, 0x70, 0xdf, 0xc3, + 0xd2, 0x03, 0x00, 0x00, } func (this *GrantAuthorization) Equal(that interface{}) bool { From d67e8b4c5fc5cf9bb019cb2e354f1f306ccb1d98 Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Wed, 9 Nov 2022 06:47:30 +0000 Subject: [PATCH 2/4] Update CHANGELOG.md --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index d1d95f6407..6a9f8240e1 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,6 +30,7 @@ Types of changes (Stanzas): "CLI Breaking" for breaking CLI commands. "API Breaking" for breaking exported APIs used by developers building on SDK. "State Machine Breaking" for any changes that result in a different AppState given same genesisState and txList. + Ref: https://keepachangelog.com/en/1.0.0/ --> @@ -45,6 +46,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (x/foundation) [\#772](https://github.com/line/lbm-sdk/pull/772) export x/foundation pool * (baseapp) [\#781](https://github.com/line/lbm-sdk/pull/781) implement method `SetOption()` in baseapp * (global) [\#782](https://github.com/line/lbm-sdk/pull/782) add unhandled return error handling +* (x/foundation) [\#790](https://github.com/line/lbm-sdk/pull/790) fix case of gov_mint_left_count in x/foundation ### Breaking Changes * (cli) [\#773](https://github.com/line/lbm-sdk/pull/773) guide users to use generate-only in messages for x/foundation authority From db54fb05243c94b8e1ce7c1e3f1c5edcba188a80 Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Wed, 9 Nov 2022 15:48:23 +0900 Subject: [PATCH 3/4] Update CHANGELOG.md --- CHANGELOG.md | 1 - 1 file changed, 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6a9f8240e1..d72239fa41 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -30,7 +30,6 @@ Types of changes (Stanzas): "CLI Breaking" for breaking CLI commands. "API Breaking" for breaking exported APIs used by developers building on SDK. "State Machine Breaking" for any changes that result in a different AppState given same genesisState and txList. - Ref: https://keepachangelog.com/en/1.0.0/ --> From d9aed4e3cf656e2da2ddcdccf3009a413fd7f5a2 Mon Sep 17 00:00:00 2001 From: Youngtaek Yoon Date: Thu, 10 Nov 2022 10:58:58 +0900 Subject: [PATCH 4/4] Update CHANGELOG.md Apply PR feedback --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d72239fa41..8d4f508efa 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,10 +45,10 @@ Ref: https://keepachangelog.com/en/1.0.0/ * (x/foundation) [\#772](https://github.com/line/lbm-sdk/pull/772) export x/foundation pool * (baseapp) [\#781](https://github.com/line/lbm-sdk/pull/781) implement method `SetOption()` in baseapp * (global) [\#782](https://github.com/line/lbm-sdk/pull/782) add unhandled return error handling -* (x/foundation) [\#790](https://github.com/line/lbm-sdk/pull/790) fix case of gov_mint_left_count in x/foundation ### Breaking Changes * (cli) [\#773](https://github.com/line/lbm-sdk/pull/773) guide users to use generate-only in messages for x/foundation authority +* (x/foundation) [\#790](https://github.com/line/lbm-sdk/pull/790) fix case of gov_mint_left_count in x/foundation ### Build, CI * (ci) [\#779](https://github.com/line/lbm-sdk/pull/779) change github action trigger rules for `release/*` and `rc*/*` branches