refactor(x/bank): remove message events including sender attribute whose information is already present in the relevant events (backport cosmos/cosmos#17273)
#1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This comment was marked as resolved.
This comment was marked as resolved.
0Tech
commented
Aug 4, 2023
0Tech
force-pushed
the
remove-keeper-sender
branch
from
39d02b3 to
62c6a4d
Compare
…whose information is already present in the relevant events (#17273)
0Tech
force-pushed
the
remove-keeper-sender
branch
from
f24d77a to
29bf70d
Compare
0Tech
force-pushed
the
remove-keeper-sender
branch
from
353de61 to
2afab69
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/v0.47.x #1066 +/- ##
===================================================
+ Coverage 62.04% 62.14% +0.10%
===================================================
Files 655 655
Lines 78983 78866 -117
===================================================
+ Hits 49004 49011 +7
+ Misses 27293 27169 -124
Partials 2686 2686
|
zemyblue
reviewed
Aug 16, 2023
There was a problem hiding this comment.
I think the AttributeKeySender of bank module is no need.
finschia-sdk/x/bank/types/events.go
Line 12 in 2afab69
The attribute is still in use, e.g. in |
Update x/authz test
But I think it can be changed finschia-sdk/x/bank/keeper/send.go Line 158 in ba75f8e |
zemyblue
approved these changes
Aug 16, 2023
jaeseung-bae
approved these changes
Aug 17, 2023
4 tasks
0Tech
added a commit
to 0Tech/finschia-sdk
that referenced
this pull request
Aug 24, 2023
…whose information is already present in the relevant events (backport cosmos/cosmos#17273) (Finschia#1066) * refactor(x/bank): remove message events including `sender` attribute whose information is already present in the relevant events (#17273) * Update CHANGELOG.md * Update x/foundation tests * Update CHANGELOG.md * Update x/foundation tests * Update other tests * Apply suggestions from code review Update x/authz test * Use sdk.AttributeKeySender in x/bank type
5 tasks
0Tech
added a commit
that referenced
this pull request
Aug 24, 2023
…whose information is already present in the relevant events (backport #1066) (#1093) * refactor(x/bank): remove message events including `sender` attribute whose information is already present in the relevant events (backport cosmos/cosmos#17273) (#1066) * refactor(x/bank): remove message events including `sender` attribute whose information is already present in the relevant events (#17273) * Update CHANGELOG.md * Update x/foundation tests * Update CHANGELOG.md * Update x/foundation tests * Update other tests * Apply suggestions from code review Update x/authz test * Use sdk.AttributeKeySender in x/bank type * Update CHANGELOG.md * Update unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch would remove duplicate
messageevents in x/bank keeper.You may refer to the PR in the upstream.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml