Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make x/foundation MsgExec propagate events (backport #1053) #1061

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 1, 2023

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the C:x/foundation x/foundation module label Aug 1, 2023
@0Tech 0Tech self-assigned this Aug 1, 2023
* Fix and update tests

* Update CHANGELOG.md

* Revert irrelevant changes
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #1061 (c05758d) into release/v0.47.x (92d75cf) will not change coverage.
Report is 1 commits behind head on release/v0.47.x.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.47.x    #1061   +/-   ##
================================================
  Coverage            62.04%   62.04%           
================================================
  Files                  655      655           
  Lines                78983    78983           
================================================
  Hits                 49004    49004           
  Misses               27293    27293           
  Partials              2686     2686           
Files Changed Coverage Δ
x/foundation/keeper/internal/exec.go 93.42% <100.00%> (ø)

@0Tech 0Tech marked this pull request as ready for review August 2, 2023 01:58
@0Tech 0Tech requested review from zemyblue and jaeseung-bae August 2, 2023 01:59
jaeseung-bae
jaeseung-bae previously approved these changes Aug 2, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech requested review from zemyblue and jaeseung-bae August 8, 2023 01:22
@0Tech 0Tech merged commit 2b7b38e into Finschia:release/v0.47.x Aug 8, 2023
@0Tech 0Tech deleted the hotfix branch August 8, 2023 03:04
@zemyblue zemyblue added this to the v0.47.3 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants