Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RequestCheckTxAsync channel count as config #753

Closed
4 tasks
zemyblue opened this issue Oct 25, 2022 · 0 comments · Fixed by #756
Closed
4 tasks

Add RequestCheckTxAsync channel count as config #753

zemyblue opened this issue Oct 25, 2022 · 0 comments · Fixed by #756

Comments

@zemyblue
Copy link
Member

Summary

Need to add the number of RequestCheckTxAsync channel as config.

Problem Definition

In function NewBaseApp(), the size of the channel is fixed to a magic number of 10000. If there could be more than 10000 requests, the concurrent checkTx would be blocked until some goroutine releases in the channel.

https://github.com/line/lbm-sdk/blob/f7d1830f85c2958fc19ae8e7f8695c566fa1a71d/baseapp/baseapp.go#L143-L157

The number of chCheckTx channel uses magic nubmer 10000.

If the size of chCheckTx is larger than the node mempool size, the node mempool will be full of transaction and could handle any more transactions into the pool;

If the size of chCheckTx is smaller than the node mempool size, it could not make full use of the concurrent checkTx feature as designed to improve the overall performance.

So, need to properly setting the chCheckTx according to the size of mempool from the underlying node.

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant