Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not stop using "oc" and "ostracon" in variable names, function names, etc? #674

Open
4 tasks
ulbqb opened this issue Sep 15, 2022 · 2 comments
Open
4 tasks
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@ulbqb
Copy link
Member

ulbqb commented Sep 15, 2022

Summary

I want to stop using "oc" and "ostracon" in variable names, function names, etc.

Problem Definition

By changing "tm" and "tendermint" in the original code to "oc" and "ostracon", a large number of non-important diffs occur, making it difficult to compare important logic with the original. This makes the task of bumping up difficult. It can also lead to bugs.

Proposal

Use the original variable names and function names as they are.
I think this has the following pros and cons.

Pros

  • We can focus on comparing only important logic, so work efficiency at bump up will be improved.
  • We can eliminates task of renaming when forking from the original.
  • We can clarify the difference in logic from the original.

Cons

  • It can be mistaken for using tendermint.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zemyblue
Copy link
Member

zemyblue commented Nov 1, 2022

@ulbqb , Is it completed?

@tkxkd0159 tkxkd0159 added priority/backlog Possibly useful, but not yet enough support to actually get it done. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed priority/backlog Possibly useful, but not yet enough support to actually get it done. labels Oct 31, 2023
@tkxkd0159
Copy link
Member

We will substitute cmt, cometbft for oc, ostracon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants