Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback new signing mechanism #433

Closed
4 tasks
zemyblue opened this issue Feb 10, 2022 · 1 comment · Fixed by #434
Closed
4 tasks

Rollback new signing mechanism #433

zemyblue opened this issue Feb 10, 2022 · 1 comment · Fixed by #434
Assignees

Comments

@zemyblue
Copy link
Member

Summary

Rollback new signing mechanism

Problem Definition

#258 's feature has the potential for a DDoS attack. If there is no gas fee for the chain, an attacker can generate a lot of traffic by generating a lot of keys and sending tx.
Even if there is a gas fee, a tx sender need to receive coins from someone because sender need to have a certain amount of coins to pay for gas fee. At this time, since accountNumber is created in the existing system, there is no case where tx can be transmitted without accountNumber. So there is no need for a new signature mechanism using the existing sig_block_height.

Proposal

Rollback #258 issue (fixed by #265 )


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@zemyblue zemyblue self-assigned this Feb 10, 2022
@zemyblue
Copy link
Member Author

We need to revert #293 by fixed #344.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant