Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased gas when using paramspace for hardcode params to gov params #134

Closed
4 tasks
brew0722 opened this issue Apr 20, 2021 · 1 comment · Fixed by #139
Closed
4 tasks

Increased gas when using paramspace for hardcode params to gov params #134

brew0722 opened this issue Apr 20, 2021 · 1 comment · Fixed by #139

Comments

@brew0722
Copy link
Contributor

Summary

Problem Definition

As various gov params were taken from paramSpace, the cost of storage gas increased.
It's not a bug, but I found out that there was a cost increase more than I expected while fixing the test case.
There is additional gas consumption as paramSpace getters such as k.getGasMultiplier(...) are called more than 4 times in various APIs such as Inistnatiate, Execute, etc. And these consume 1015 per time.
So, totally more consumed additionally over than 4k when every API called.

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@brew0722 brew0722 changed the title Increased gas consumption when using paramspace for hardcode params to gov params Increased gas when using paramspace for hardcode params to gov params Apr 20, 2021
@brew0722 brew0722 linked a pull request Apr 27, 2021 that will close this issue
9 tasks
@whylee259 whylee259 reopened this May 10, 2021
@loloicci loloicci self-assigned this May 10, 2021
@loloicci
Copy link
Contributor

solved by #198.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants