Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try MsgModify with invalid tokenIndex, does not blocking. #1101

Closed
4 tasks
hyenjong-yoo opened this issue Aug 29, 2023 · 2 comments · Fixed by #1102
Closed
4 tasks

Try MsgModify with invalid tokenIndex, does not blocking. #1101

hyenjong-yoo opened this issue Aug 29, 2023 · 2 comments · Fixed by #1102
Assignees
Labels
A: bug Something isn't working C:x/collection
Milestone

Comments

@hyenjong-yoo
Copy link

Summary of Bug

lbm.collection.v1.MsgModify
AS-IS : Request MsgModify to Invalid TokenIndex with valid NFT TokenIndex, but response not correct event type_name's value <lbm.collection.v1.FTClass>

request ex) MsgModify.fromPartial({
    "contractId": "contractId",
    "owner": "owner",
    "tokenType": "10000001",
    "tokenIndex": "00000000",
    "changes": "changes"
})
response ex)
{
    "events":
    [
        {
            "type": "lbm.collection.v1.EventModifiedTokenClass",
            "attributes":
            [
                {
                    "key": "changes",
                    "value": "[{key:name,value:nFrameworkFT2}]"
                },
                {
                    "key": "contract_id",
                    "value": "3ee3e2f6"
                },
                {
                    "key": "operator",
                    "value": "tlink1fpgj0gg6w4f2f642qsrkgrswj9jdmeer8s9ffx"
                },
                {
                    "key": "token_type",
                    "value": "10000001"
                },
                {
                    "key": "type_name",
                    "value": "lbm.collection.v1.FTClass"
                }
            ]
        },
        {
            "type": "message",
            "attributes":
            [
                {
                    "key": "action",
                    "value": "/lbm.collection.v1.MsgModify"
                }
            ]
        }
    ]
}

TO-BE :
Blocking Invalid NFT Token Index MsgModify

Version

v0.47.1-rc2
v0.47.3-0.20230817110929-1df6411c6429

Steps to Reproduce

  1. Create Collection and Issue NFT token and Mint NFT
  2. Make MsgModify with tokenType = 10000001, tokenIndex=00000000
  3. Send Tx and Check Tx Response

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@0Tech
Copy link
Collaborator

0Tech commented Aug 29, 2023

Thank you for the report. The chain must reject the request, including a tokentype of nft class and token index of "00000000". The specification is of daphne, hence the current implementation is not compatible with the old spec.

@zemyblue zemyblue added this to the v0.48.0 milestone Aug 30, 2023
@zemyblue zemyblue linked a pull request Aug 30, 2023 that will close this issue
5 tasks
@0Tech
Copy link
Collaborator

0Tech commented Sep 4, 2023

The linked PR should have fixed the bug. You may reopen this issue if you come up with any relevant problem. Thank you @hyenjong-yoo.

@0Tech 0Tech closed this as completed Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working C:x/collection
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants