-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable sign ext for wasm generated with rust 1.70 #344
Conversation
This fix Finschia#338. And, this will be replaced with wasmparser in feature version. (CosmWasm/cosmwasm#1786)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we replace parity-wasm with wasmer::wasmparser?
Upstream already applied it and I assume there is no dependency to apply this.
@tkxkd0159 It has already been merged into the bump_1.5.1 branch, do you mean that we need to merge it into the main branch first? https://github.com/Finschia/cosmwasm/blob/feat/bump_1.5.1/packages/vm/src/cache.rs#L17 |
This is because some interfaces of wasmparser in wasmer 4.1.0 used by CosmWasm/cosmwasm#1786 is not compatible with wasmer 2.3.0 which we use in main.
|
Okay, I understand now. LGTM |
Description
This PR enable sign-ext feature of parity wasm.
This allows wasm to use some additional operators which are sometimes used in wasm generated with rust1.70.
This fix #338.
And, this will be replaced with wasmparser in a feature version (CosmWasm/cosmwasm#1786).
Types of changes
Checklist