Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unique handling of servers (Triage on ostracon#515) #15

Open
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 2 comments
Open
Tracked by #1

Add unique handling of servers (Triage on ostracon#515) #15

0Tech opened this issue Nov 1, 2023 · 2 comments
Assignees
@Mdaiki0730
Labels
A: improvement Changes in existing functionality priority/major

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023 •
edited by Mdaiki0730
Loading

The subject of the triage:
@0Tech 0Tech mentioned this issue Nov 1, 2023
Open
50 tasks
@Mdaiki0730
Copy link
Member

It seems that it is not applied as of v0.38.0.
I think it is better to send the PR upstream to prevent security degradation due to cross-checking with the light client's primary.
https://github.com/cometbft/cometbft/blob/v0.38.0/statesync/stateprovider.go#L48-L86

@Mdaiki0730 Mdaiki0730 changed the title Triage on ostracon#515 Add unique handling of servers (Triage on ostracon#515) Nov 6, 2023
@Mdaiki0730
Copy link
Member

Additional discussion is required.

servers is given by config.StateSync.RPCServers.
https://github.com/cometbft/cometbft/blob/v0.38.0/node/node.go#L204

If you check the value passed during test, RPCAddress will be entered in RPCServers.
https://github.com/cometbft/cometbft/blob/v0.38.0/test/e2e/runner/setup.go#L229
https://github.com/cometbft/cometbft/blob/main/test/e2e/pkg/testnet.go#L552

This duplication therefore helps create clients and providers to the same address.

@Mdaiki0730 Mdaiki0730 added A: improvement Changes in existing functionality and removed needs-triage labels Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mdaiki0730 Mdaiki0730

Labels
A: improvement Changes in existing functionality priority/major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0Tech @Mdaiki0730