Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error when AddChannel fails (Triage on ostracon#500) #13

Open
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 2 comments
Open
Tracked by #1

Return error when AddChannel fails (Triage on ostracon#500) #13

0Tech opened this issue Nov 1, 2023 · 2 comments
Assignees
@Mdaiki0730
Labels
needs-triage priority/major

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023 •
edited by Mdaiki0730
Loading

The subject of the triage:
@0Tech 0Tech mentioned this issue Nov 1, 2023
Open
50 tasks
@Mdaiki0730
Copy link
Member

Mdaiki0730 commented Nov 2, 2023 •
edited
Loading

It seems that it is not applied as of v0.38.0.
By reflecting this PR, you can add proper error handling.
https://github.com/cometbft/cometbft/blob/v0.38.0/p2p/transport.go#L272-L279

In particular, it is not specified why error is no longer returned as a return value.
tendermint/tendermint@03393fb

@Mdaiki0730 Mdaiki0730 changed the title Triage on ostracon#500 return error when AddChannel fails (Triage on ostracon#500) Nov 6, 2023
@Mdaiki0730 Mdaiki0730 changed the title return error when AddChannel fails (Triage on ostracon#500) Return error when AddChannel fails (Triage on ostracon#500) Nov 6, 2023
@Mdaiki0730
Copy link
Member

Additional discussion is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mdaiki0730 Mdaiki0730

Labels
needs-triage priority/major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0Tech @Mdaiki0730