From 59c8c57d95c62cd1e333e1394fcceb64fd39380a Mon Sep 17 00:00:00 2001 From: "ben.freshwater" Date: Tue, 7 Jan 2025 15:43:15 +0000 Subject: [PATCH 1/3] fix: use square buttons on o-header --- components/o-header/main.scss | 1 + components/o-header/src/scss/features/_drawer.scss | 1 + components/o-header/src/scss/features/_search.scss | 1 + components/o-header/src/scss/features/_transparent.scss | 1 + 4 files changed, 4 insertions(+) diff --git a/components/o-header/main.scss b/components/o-header/main.scss index cfe5a51179..4643cab61e 100644 --- a/components/o-header/main.scss +++ b/components/o-header/main.scss @@ -70,6 +70,7 @@ 'theme': 'mono', ) ); + border-radius: 0; } } diff --git a/components/o-header/src/scss/features/_drawer.scss b/components/o-header/src/scss/features/_drawer.scss index e1cbb4a739..8f1b32351e 100644 --- a/components/o-header/src/scss/features/_drawer.scss +++ b/components/o-header/src/scss/features/_drawer.scss @@ -208,6 +208,7 @@ 'size': 'big', ) ); + border-radius: 0; } // diff --git a/components/o-header/src/scss/features/_search.scss b/components/o-header/src/scss/features/_search.scss index 6e509b2001..5f5e4ee11e 100644 --- a/components/o-header/src/scss/features/_search.scss +++ b/components/o-header/src/scss/features/_search.scss @@ -66,6 +66,7 @@ 'size': 'big', ) ); + border-radius: 0; display: flex; gap: 10px; align-items: center; diff --git a/components/o-header/src/scss/features/_transparent.scss b/components/o-header/src/scss/features/_transparent.scss index a236d95d1d..29b85634d0 100644 --- a/components/o-header/src/scss/features/_transparent.scss +++ b/components/o-header/src/scss/features/_transparent.scss @@ -51,6 +51,7 @@ 'theme': 'inverse', ) ); + border-radius: 0; } .o-header__nav-link, From 793704cb892989a6cd45f289622d7dfbd4fd8e8d Mon Sep 17 00:00:00 2001 From: "ben.freshwater" Date: Tue, 7 Jan 2025 16:45:29 +0000 Subject: [PATCH 2/3] fix: fix text positioning on subscribe button, align ask ft padding to other buttons --- components/o-header/src/scss/_mixins.scss | 2 +- components/o-header/src/scss/features/_drawer.scss | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/components/o-header/src/scss/_mixins.scss b/components/o-header/src/scss/_mixins.scss index 0d8735b6b5..9dac89f5c8 100644 --- a/components/o-header/src/scss/_mixins.scss +++ b/components/o-header/src/scss/_mixins.scss @@ -123,7 +123,7 @@ display: flex; align-items: center; gap: 4px; - padding: 6px 8px; + padding: 4px 8px; color: _oHeaderGet('header-ask-ft-button-text'); background-color: _oHeaderGet('header-ask-ft-button-background'); border-radius: 4px; diff --git a/components/o-header/src/scss/features/_drawer.scss b/components/o-header/src/scss/features/_drawer.scss index 8f1b32351e..3e50ff55d8 100644 --- a/components/o-header/src/scss/features/_drawer.scss +++ b/components/o-header/src/scss/features/_drawer.scss @@ -149,7 +149,7 @@ } .o-header__drawer-button { - display: block; + width: 100%; } // From 573b71c4a136ffc1f443ff8a195e64cead7da177 Mon Sep 17 00:00:00 2001 From: "ben.freshwater" Date: Wed, 8 Jan 2025 09:40:15 +0000 Subject: [PATCH 3/3] fix: fix lint issues --- components/o-header/src/scss/features/_drawer.scss | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/components/o-header/src/scss/features/_drawer.scss b/components/o-header/src/scss/features/_drawer.scss index 3e50ff55d8..ebd894b14b 100644 --- a/components/o-header/src/scss/features/_drawer.scss +++ b/components/o-header/src/scss/features/_drawer.scss @@ -18,11 +18,7 @@ border-right: 1px solid _oHeaderGet('drawer-border'); // use a 2D transform because 3D are unsupported by IE9 transform: translateX(-100%); - transform: translate3d( - -100%, - 0, - 0 - ); // stylelint-disable-line declaration-block-no-duplicate-properties + transform: translate3d(-100%, 0, 0); // stylelint-disable-line declaration-block-no-duplicate-properties // this is literally the specification example for will-change will-change: transform; @@ -38,11 +34,7 @@ &.o-header__drawer--open { // use a 2D transform because 3D are unsupported by IE9 transform: translateX(0); - transform: translate3d( - 0, - 0, - 0 - ); // stylelint-disable-line declaration-block-no-duplicate-properties + transform: translate3d(0, 0, 0); // stylelint-disable-line declaration-block-no-duplicate-properties } } }