Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle type of 'image' is not supported despite javapackager command line accepting it #92

Open
swpalmer opened this issue Nov 25, 2017 · 3 comments

Comments

@swpalmer
Copy link

swpalmer commented Nov 25, 2017

When I set

jfx {
    bundler = 'image'
}

I get:

* What went wrong:
Execution failed for task ':MyProject:jfxNative'.
> No bundler found for given name image. Please check your configuration.

However help output of javapackager indicates:

-native
generate self-contained application bundles (if possible).
If type is specified then only bundle of this type is created.
List of supported types includes: installer, image, exe, msi, dmg, rpm, deb.

and sure enough 'image' is accepted on the command line

@FibreFoX
Copy link
Owner

Yes, this was intentionally. In previous versions of the JDK 8 there seemed to be no further use of that filtering-type, and I personally find it better to have tighter control about the generated files than "just anything possible".

Does this really feel missing?

@swpalmer
Copy link
Author

I think so. "image" doesn't mean "just anything possible". That's what not specifying any bundler means. "image" however, creates the application bundle with the java launcher, .cfg files, app folder, runtime folder, etc., and then I can incorporate those files into a custom installer.

@FibreFoX
Copy link
Owner

There were four values as an enum:

NONE, IMAGE, INSTALLER, ALL

The problem with this is, that you have no real control about what bundler will get used. This is kind of a bundler-group-name, where NONE and ALL had special meaning.
Looking at the JDK 10 this still seems to be existing, but the whole concept feels broken for me.

Will re-evaluate this the next days.

@FibreFoX FibreFoX added this to the project rework milestone Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants