Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Comments are not hidden #7

Closed
caglarongan opened this issue Feb 7, 2024 · 3 comments
Closed

[BUG] Comments are not hidden #7

caglarongan opened this issue Feb 7, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@caglarongan
Copy link

Comments are not hidden even though I've selected "inline-icon" or "inline" rendering selected.

Screenshot 2024-02-07 at 03 25 14 Screenshot 2024-02-07 at 03 25 10

Very high-quality plugin, very appreciated! Thanks and congrats :)

@Fevol Fevol self-assigned this Feb 9, 2024
@Fevol Fevol added the bug Something isn't working label Feb 9, 2024
@Fevol
Copy link
Owner

Fevol commented Feb 9, 2024

Thank you for the bug report, and the kind words!

I think that you are currently in Source Mode, which is why the comments are not being shown as an icon. Could you test if Toggle Live Preview/Source mode solves the issue?

@caglarongan
Copy link
Author

Ah yes, it works as expected in Live Preview. Thank you.

But for Reading Mode, it's still rendered inline and not hidden.

Also, multi-line comments are rendered like this:

source view reading mode

@Fevol Fevol closed this as completed in 7bc5cb9 Mar 5, 2024
@Fevol Fevol reopened this Mar 5, 2024
@Fevol
Copy link
Owner

Fevol commented Mar 6, 2024

Thank you for the bug report, with the latest version 0.2.0, the comments are now rendered like in live preview mode (i.e. comment icon), when hovering over the icon, the comment contents will appear.

If you have suggestions on how to improve comment rendering in reading mode, please feel free to open up a new issue!

@Fevol Fevol closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants