Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits of the suggestion #5

Closed
felipemeres opened this issue Nov 10, 2023 · 3 comments
Closed

Edits of the suggestion #5

felipemeres opened this issue Nov 10, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@felipemeres
Copy link

felipemeres commented Nov 10, 2023

Incredible plugin, thank you so much for working on it! I'm wondering if it would be possible to add a setting so that edits to suggestions don't get crossed out if edited but actually just permanently edit the suggestion.

@Fevol Fevol self-assigned this Nov 10, 2023
@Fevol Fevol added the enhancement New feature or request label Nov 10, 2023
@Fevol
Copy link
Owner

Fevol commented Nov 10, 2023

Just so I understand correctly, is this somewhat the situation you're envisioning? I.e. (1) instead of (2):

  1. {++abc░++} ---(backspace)--> {++ab░++} (c gets fully deleted)
  2. {++abc░++} ---(backspace)--> {++ab░++}{--c--} (c gets marked as a deletion)

If so, this is definitely something I'm planning to add when I finally get around to the suggestion mode rewrite.
My main goal is recreating the behaviour of Google Docs' suggestion mode, for better and worse, though with the addition of being able to fully delete characters while pressing the modifier key Alt, for example. (And having a command to invert the behaviour at will)

@huachuman
Copy link

Level 10,000 developer here ^

You can just tell because of the way it is.

You are on a rocket to success my friend.

Thank you for this superb plugin.

@Fevol Fevol closed this as completed in 21b1d50 Mar 5, 2024
@Fevol Fevol reopened this Mar 5, 2024
@Fevol
Copy link
Owner

Fevol commented Mar 6, 2024

Thank for the patience, with version 0.2.0, there are now two different solutions to this problem:

  1. In suggestion mode, when strictly in the addition or the addition-part of a substitution, a delete will always remove the text (similar to how Google Docs' logic works)
  2. In alternative editing mode (the new default editing mode), you can directly insert and delete text from any suggestion

@Fevol Fevol closed this as completed Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants