Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "Accept Changes" to Delete Comment? #17

Open
kerim opened this issue May 10, 2024 · 5 comments
Open

Allow "Accept Changes" to Delete Comment? #17

kerim opened this issue May 10, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@kerim
Copy link

kerim commented May 10, 2024

RIght now, adding a comment shows it on the sidebar, but I would like to be able to also delete comments from the sidebar as well. Each comment shows the check and "X" for accepting or rejecting changes, but these don't seem to do anything for comments. I'd like to be able to use the checkmark to delete comments I've already processed. This is similar to how comments work in Google Docs.

@lifehaschanged
Copy link

Hello Kerim. Sorry for the question - I am new to this plugin: How do you make the comment sidebar visible? I have no command for this after installing the plugin.

@lifehaschanged
Copy link

Did you install it with BRAT or manually, because with BRAT I have no commands or sidebars visible in a fresh sandbox vault?

@kerim
Copy link
Author

kerim commented May 10, 2024

There is a button at the top of the sidebar that gives you a few of all suggestions and/or comments. You can cycle between showing them for the individual file, the current folder, or the entire vault. I used BRAT to install.

@lifehaschanged
Copy link

Thanks, I opened a new Issue. And +1 for your FR.

@Fevol
Copy link
Owner

Fevol commented May 10, 2024

Thank you for the feature request! Currently this is indeed unimplemented as I still need to work out how the comment resolving workflow should be added. (E.g. mark as completed using metadata and still being available for later reference, or completely removing it)

Currently the development of the plugin is on hold as I am trying to focus on other work, but I should finally be able to get around to this in a month's time.

@Fevol Fevol self-assigned this May 10, 2024
@Fevol Fevol added the enhancement New feature or request label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants