-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt proper names for entities with different dimensions and codimensions #901
Comments
Note that as a user you already have to update |
It would be visually a bit confusing to have both face and facet in exported names, but perhaps the face versions can be |
True. I'm more concerned about |
Perhaps we can just keep |
One option would be to introduce the user function |
Thanks for putting together the issue Knut!
Can you elaborate what kind of warning/error path you have in mind?
Let us think further about this naming. Regarding
Regarding |
FaceValues(fqr, ip)
Error: FaceValues are deprecated, use FacetValues instead
addfaceset(grid, args...)
Error: addfaceset is deprecated, use addfacetset instead
getfaceset(grid, ...)
... where we could also For |
for i in 1:10
@warn "Beep boop, you will only see 🦦 once" maxlog=1
end |
Many issues seem to stem from not having a clear distinction between dimension and codimension.
Adopting the correct names (ref defelement) in Ferrite would be a major change, especially since users would have to change from
FaceValues
/faceset
/FaceIndex
toFacetValues
/facetset
/FacetIndex
.However, it seems to have the benefit of making the code more understandable and extensible as we add more advanced features. It is notable that at least
fenics
adopts this defintion.Ref discussions in #899, #767, #789 (and probably more).
Most user calls would occur during construction, so that a regular warning / upgrade error would be feasible for standard users. IMO this should happen before releasing 1.0 or not at all.
Edit: I earlier mistakenly assumed these names were part of the Ciarlet (1978) definitions, but couldn't find any references to this, and AFAIU now that only refers to the triplet$(\mathcal{R},\ \mathcal{V}, \mathcal{L})$ for the reference shape, interpolation space, and unknowns/nodal values which we implicitly already have. Changed the name to reflect this.
The text was updated successfully, but these errors were encountered: