Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractFunctionValues #837

Closed
KnutAM opened this issue Nov 9, 2023 · 1 comment
Closed

AbstractFunctionValues #837

KnutAM opened this issue Nov 9, 2023 · 1 comment

Comments

@KnutAM
Copy link
Member

KnutAM commented Nov 9, 2023

Adding this here as a reminder and in case the discussion here enters the Slack hole.

To be considered after #764 and #798

Currently, there are PointValues and PointValuesInternal which allow updating the quadrature point location. PointValues just contains a CellValues whose quadrature points are updated during reinit!, and PointValuesInternal has only the shape values in the reference domain (which for identity mapping are the same as in the spatial domain).

If we introduce AbstractFunctionValues or another way to have multiple variants of FunctionValues (see #764), which each have a different number of derivatives, we can use these to construct AbstractValues which are able to give only the value (current PointValuesInternal only), value and 1st derivative (current CellValues, FaceValues, PointValues), or value + 1st and 2nd order derivatives (currently not implemented, but requested).
(This would also merge PointValuesInternal into PointValues and make it possible to expose this API for use in e.g. FerriteViz.jl)

@KnutAM
Copy link
Member Author

KnutAM commented Jan 22, 2024

The merged FunctionValues has the DiffOrder type parameter and PointValues and PointValuesInternal are merged. The API for requesting a different DiffOrder is not public/documented yet, since we might want to change the API after introducing the option of adding DiffOrder higher than 1.

With that generalization, I think this issue can be closed. If AbstractFunctionValues comes up again but for a different reason, that would be a separate issue.

@KnutAM KnutAM closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants