Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize topology construction #670

Merged
merged 11 commits into from
May 9, 2023
Merged

Conversation

termi-official
Copy link
Member

@termi-official termi-official commented Apr 3, 2023

Closes #641 and #684 .

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2023

Codecov Report

Patch coverage: 93.75% and project coverage change: -2.37 ⚠️

Comparison is base (363462b) 92.92% compared to head (4da9151) 90.56%.

❗ Current head 4da9151 differs from pull request most recent head 08cd31f. Consider uploading reports for the commit 08cd31f to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #670      +/-   ##
==========================================
- Coverage   92.92%   90.56%   -2.37%     
==========================================
  Files          30       30              
  Lines        4398     4408      +10     
==========================================
- Hits         4087     3992      -95     
- Misses        311      416     +105     
Impacted Files Coverage Δ
src/Dofs/DofHandler.jl 92.35% <0.00%> (-0.30%) ⬇️
src/Grid/grid.jl 92.85% <95.74%> (-0.14%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

src/Grid/grid.jl Outdated Show resolved Hide resolved
@termi-official termi-official marked this pull request as ready for review April 4, 2023 20:33
@termi-official
Copy link
Member Author

Tandem with Ferrite-FEM/FerriteViz.jl#74 .

@termi-official termi-official changed the title Update topology construction Generalize topology construction Apr 4, 2023
src/Grid/grid.jl Outdated Show resolved Hide resolved
src/Grid/grid.jl Show resolved Hide resolved
src/Grid/grid.jl Outdated Show resolved Hide resolved
Copy link
Member

@koehlerson koehlerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that lgtm

src/Grid/grid.jl Show resolved Hide resolved
src/Grid/grid.jl Outdated Show resolved Hide resolved
src/Grid/grid.jl Outdated Show resolved Hide resolved
@termi-official termi-official linked an issue May 5, 2023 that may be closed by this pull request
src/Grid/grid.jl Outdated Show resolved Hide resolved
@termi-official
Copy link
Member Author

Ready for take off @fredrikekre

@termi-official termi-official merged commit 2fe73a2 into master May 9, 2023
@termi-official termi-official deleted the do/update-topology-interface branch May 9, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topology construction for 1D elements is broken Topology broken for wedges
4 participants