Deprecate push!(dh, ...) in favor of add!(dh, ...)
#578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimauth
approved these changes
Jan 9, 2023
This patch deprecates `push!(dh::DofHandler, ...)` in favor of `add!(dh,...)`. This is to make it consistent with how constraints are added to the constraint handler, and using `Base.push!` for this was a bit of a pun anyway.
Codecov ReportBase: 92.76% // Head: 92.76% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #578 +/- ##
=======================================
Coverage 92.76% 92.76%
=======================================
Files 28 28
Lines 4202 4202
=======================================
Hits 3898 3898
Misses 304 304
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch deprecates
push!(dh::DofHandler, ...)in favor ofadd!(dh,...). This is to make it consistent with how constraints are added to the constraint handler, and usingBase.push!for this was a bit of a pun anyway.