jackson-module-jaxb-annotations 2.11.2 has wrong module info (Java 9 instead of Java 11)

[oleg-nenashev]

Looks like there are some minor issues in jackson-module-jaxb-annotations 2.12.1 multi-release JAR.
It looks like Java 9 - focused class is used instead. Not a big deal, but there is a warning generated by Maven Enforcer Plugin.

[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (display-info) @ MY_PROJECT ---
[INFO] Ignoring requireUpperBoundDeps in com.google.guava:guava
[INFO] Adding ignore: module-info
[WARNING] Invalid bytecodeVersion for com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.12.1:compile : META-INF/versions/11/module-info.class: expected 55, but was 53

[cowtowncoder]

I think this is due to improvements by @GedMarc -- Java 9 is not a LTS so we probably don't care about it, but seems odd there'd be complaint by Maven enforcer plug-in. Maybe there's need to upgrade version of that plugin?

[GedMarc]

closable

[timja]

This also happens on java 11 for the record

[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (display-info) @ azure-credentials ---
[INFO] Adding ignore: module-info
Invalid bytecodeVersion for com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.12.2:compile : META-INF/versions/11/module-info.class: expected 55, but was 53

[cowtowncoder]

If anyone has ideas of how to address that, I'm all ears. But as of now I don't know what, if anything, to do.
Seems like some verifier is expecting bytecode to be compiled targeting Java 11, but it was Java 9. Not sure why that would be considered harmful (reverse would be).

[GedMarc]

arg, we can move it to version/9 instead of 11

it is a setting in moditect

[GedMarc]

looks like an enforcer minimum jdk version setting actually -

just update enforcer to allow versions 9 and up, otherwise we'll compile module-info to version 11

[GedMarc]

i still feel java 9 is the right version of the module-info.class to allow for everyone,
@timja Why do have enforcer set for a minimum JDK version for items in META-INF?

[GedMarc]

For JDK 11 your minimum allowable java version should be 8, version 7 is no longer compilable -
For JDK 16 your minimum java version should be 9

[timja]

Which is what we have as far as I can tell
https://github.com/jenkinsci/plugin-pom/blob/master/pom.xml#L477

[GedMarc]

@cowtowncoder happy with me putting the moditect files into META-INF/versions/9 so the enforcer succeeds

It is technically correct in validating the class version with the version in the META-INF folder -
I don't believe we should try bump the class version up

[cowtowncoder]

Ok so enforcer setting of which project? If it is mistaken validation by enforcer plugin outside jackson components I am not sure we should change anything.

[GedMarc]

Ok -
So this will probably need an issue logged in the enforcer plugin,

What is happening is for each versions, the plugin is checking for the exact version number, rather than the allowed [min.jdk,max.jdk] class files in these directories

This is specific to enforcer in the jenkins-ci pom

[GedMarc]

Ok @cowtowncoder

For moditect --

<plugin>...
<configuration>....
<version>9</version>

I'll start with the jakarta module base, i've spoken with the moditect guys (luke hutch), the module info must be compiled as version 9 (not 11), but for sniffers and accuracy, it should be placed under version 9 directory in META-INF, not 11

[cowtowncoder]

So, this is wrt FasterXML/jackson-databind#3380 as well, right?

I think this change needs to go in 2.13(.2), and the place, I think is in base/pom.xml of jackson-bom project?
If so, all actual Jackson repos should start using it.