Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed patch to issue #24 #25

Merged
merged 5 commits into from
Oct 15, 2013
Merged

Proposed patch to issue #24 #25

merged 5 commits into from
Oct 15, 2013

Conversation

idelvall
Copy link
Contributor

See #24

Schemas with additional properties were not properly serialized.
@cowtowncoder
Copy link
Member

Sounds good. Would it be possible to have a simple unit test for this? :-)

@idelvall
Copy link
Contributor Author

Of course

@idelvall
Copy link
Contributor Author

Here there are, tell me how you see it

@idelvall idelvall closed this Oct 15, 2013
@cowtowncoder
Copy link
Member

I assume closing was accidental, reopening.

@cowtowncoder cowtowncoder reopened this Oct 15, 2013
@cowtowncoder
Copy link
Member

Looks good & I will merge.

One minor comment for future: could you try not to reformat existing classes? It's probably an IDE setting or such; just prefer not cosmetic change as they increase diffs and can sometimes hide actual functional changes.

cowtowncoder added a commit that referenced this pull request Oct 15, 2013
Proposed patch to issue #24 -- thanks!
@cowtowncoder cowtowncoder merged commit 373ccc4 into FasterXML:master Oct 15, 2013
@idelvall
Copy link
Contributor Author

Ok, sorry for the refactoring.

@cowtowncoder
Copy link
Member

No prob -- thank you for the fix!

@idelvall
Copy link
Contributor Author

yw, thank you for this useful project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants