Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serializing an Iterator with multiple sub-types fails after upgrading to 2.9.x #1977

Closed
shiv-sivaram opened this issue Mar 20, 2018 · 2 comments
Milestone

Comments

@shiv-sivaram
Copy link

Hello,

I recently upgraded my jackson version 2.8.7 to 2.9.4 and serialization of an iterator with multiple sub-types seems broken.

Code to recreate the issue:

import com.fasterxml.jackson.databind.ObjectMapper;

import java.util.ArrayList;
import java.util.Iterator;

public class JacksonErrorTest {

    private static Iterator<Number> numbers;
    private static final ObjectMapper MAPPER = new ObjectMapper();

    public static void main(String[] args) throws Exception {

        ArrayList<Number> numbersList = new ArrayList<>();
        numbersList.add(1);
        numbersList.add(1.0);
        numbers = numbersList.iterator();
        MAPPER.writeValueAsString(numbers);
    }
}

The exception stack trace is:

Exception in thread "main" com.fasterxml.jackson.databind.JsonMappingException: java.lang.Double cannot be cast to java.lang.Integer
	at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider._wrapAsIOE(DefaultSerializerProvider.java:509)
	at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider._serialize(DefaultSerializerProvider.java:482)
	at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider.serializeValue(DefaultSerializerProvider.java:319)
	at com.fasterxml.jackson.databind.ObjectMapper._configAndWriteValue(ObjectMapper.java:3893)
	at com.fasterxml.jackson.databind.ObjectMapper.writeValueAsString(ObjectMapper.java:3207)
	at JacksonErrorTest.main(JacksonErrorTest.java:21)
Caused by: java.lang.ClassCastException: java.lang.Double cannot be cast to java.lang.Integer
	at com.fasterxml.jackson.databind.ser.std.NumberSerializers$IntegerSerializer.serialize(NumberSerializers.java:137)
	at com.fasterxml.jackson.databind.ser.impl.IteratorSerializer._serializeDynamicContents(IteratorSerializer.java:120)
	at com.fasterxml.jackson.databind.ser.impl.IteratorSerializer.serializeContents(IteratorSerializer.java:80)
	at com.fasterxml.jackson.databind.ser.impl.IteratorSerializer.serialize(IteratorSerializer.java:67)
	at com.fasterxml.jackson.databind.ser.impl.IteratorSerializer.serialize(IteratorSerializer.java:13)
	at com.fasterxml.jackson.databind.ser.DefaultSerializerProvider._serialize(DefaultSerializerProvider.java:480)
	... 4 more

It looks like the error is on this line:
https://github.com/FasterXML/jackson-databind/blob/master/src/main/java/com/fasterxml/jackson/databind/ser/impl/IteratorSerializer.java#L109
serializers.serializerFor(cc);
should be
serializer = serializers.serializerFor(cc);

@cowtowncoder
Copy link
Member

Thank you for reporting this problem -- I'll have a look.

@cowtowncoder cowtowncoder added this to the 2.9.5 milestone Mar 20, 2018
@shiv-sivaram
Copy link
Author

Thank you for the super fast turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants