Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Add conda release #5

Closed
pseudo-rnd-thoughts opened this issue Sep 8, 2022 · 12 comments
Closed

[Proposal] Add conda release #5

pseudo-rnd-thoughts opened this issue Sep 8, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@pseudo-rnd-thoughts
Copy link
Member

With the ability to make github actions on release, add conda releases to github release workflow

@pseudo-rnd-thoughts pseudo-rnd-thoughts added the enhancement New feature or request label Sep 8, 2022
@kir0ul
Copy link
Contributor

kir0ul commented Sep 14, 2022

Why not using the standard conda-forge channel?
I'm asking this because it seems to me that the existing tooling built around conda-forge is hard to match with any simpler GH Action, which could mean less maintenance in the long run.

@pseudo-rnd-thoughts pseudo-rnd-thoughts changed the title [Proposal] Add conda channel [Proposal] Add conda release Sep 14, 2022
@pseudo-rnd-thoughts
Copy link
Member Author

pseudo-rnd-thoughts commented Sep 14, 2022

Agreed, looking at it more, I think we just need to make a staged recipe for the project with each of the options

I have edited the title from channel to recipe

@kir0ul
Copy link
Contributor

kir0ul commented Sep 17, 2022

I was looking a bit into it, the first problem I encountered is that pygame is not packaged for Conda (but I guess you knew that already) and from what I could read it looks pretty tricky to package, but I'll try to have a look anyway.

Related issues: pygame/pygame#1953, conda-forge/staged-recipes#19665, pygame/pygame#3320, pygame/pygame#3415.

@h-vetinari
Copy link

h-vetinari commented Dec 7, 2022

gym is already in conda-forge, including most of the optional outputs (but stuck on 0.21 due to the addition of the extremely tricky pygame dependency with 0.22). please help us get things packaged there rather than do your own thing. Though the good news is that conda-forge/staged-recipes#19665 seems to be nearing completion...

@jjyyxx
Copy link
Contributor

jjyyxx commented Feb 25, 2023

I apologize for interrupting the thread, but I was curious about the progress of the "Official Conda packaging" mentioned in Roadmap #12. Since February is coming to an end, I was wondering if there are any updates you could share with us regarding the status of this feature. Thank you for your time and efforts!

@pseudo-rnd-thoughts
Copy link
Member Author

@h-vetinari has been doing an amazing job on conda, and there already exists a conda install for gymnasium.
https://github.com/conda-forge/gymnasium-feedstock

@h-vetinari
Copy link

We don't have 0.27 yet as there'll be some new dependencies that'll take some work. Join the discussion in conda-forge/gymnasium-feedstock#1 if you want, and any help is always welcome (I can try to help out, but probably won't be able to lead this effort; the gym->gymnasium transition already took a bunch of time I didn't really have planned for this 🙃).

@pseudo-rnd-thoughts
Copy link
Member Author

Gymnasium on conda has been updated to the latest version, thank you to @h-vetinari and @ChristofKaufmann for all of their hardwork
https://github.com/conda-forge/gymnasium-feedstock

@h-vetinari
Copy link

Happy to hear it!

Now that we've caught up in terms of versions, it's would probably be worth mentioning under the installation instructions? We also support windows. :)

conda install -c conda-forge gymnasium  # or "gymnasium-all" for all supported optional extensions

@pseudo-rnd-thoughts
Copy link
Member Author

yes, good point, @h-vetinari could you make a pr for this?

@h-vetinari
Copy link

yes, good point, @h-vetinari could you make a pr for this?

This seems to have fallen through the cracks, sorry - anyone else up for it?

@pseudo-rnd-thoughts
Copy link
Member Author

Is this just a documentation update? Sorry, I have forgotten what we wanted to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants