Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Voltage Reference - Code Cleaning #34

Open
kb1lqd opened this issue Oct 25, 2016 · 0 comments
Open

Internal Voltage Reference - Code Cleaning #34

kb1lqd opened this issue Oct 25, 2016 · 0 comments

Comments

@kb1lqd
Copy link
Contributor

kb1lqd commented Oct 25, 2016

Overview

During code doxygen documentation the internal voltage reference HAL was found to have unclear or confusing programming.

This issue is focusing on the "ref.h" and "ref.c" files.

Enable Reference Wording

void Enable_Reference(unsigned char set);

This is a confusing function name. It should be split in the future to a specific enable/disable function with no function argument.

Enable External Reference Output

void Enable_Reference_External_Output(unsigned char set);

This is a confusing function name. It should be split in the future to a specific enable/disable function with no function argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant