Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug report #777

Closed
LuckyTil opened this issue Jan 20, 2024 · 11 comments
Closed

Bug report #777

LuckyTil opened this issue Jan 20, 2024 · 11 comments
Labels

Comments

@LuckyTil
Copy link

Far Manager version

3.0.6226.0

OS version

10.0.22631.3007

Other software

No response

Steps to reproduce

  1. Open attachment
  2. Analyze content
    Far_20240120_202126566_8640.7z.zip

Expected behavior

No response

Actual behavior

See attachment

@LuckyTil LuckyTil added the bug label Jan 20, 2024
@LuckyTil
Copy link
Author

@HamRusTal
Copy link
Contributor

HamRusTal commented Jan 20, 2024

This Issue lacks all key elements of a good bug report: a specific concise yet meaningful title, clear Steps to Reproduce, unambiguous Expected and Actual behavior. These should not be buried in numerous attached archives without a very solid reason (and the reason, if any, has to be explained).
I suggest that this issue is either reworked fundamentally or rejected right away.

@alabuzhev
Copy link
Contributor

Meh. Sometimes a memory dump is way better than any user stories.

I see that:

  • the user pressed enter on a png file
  • far read some data from it and started demonstrating it to plugins
  • eventually it reached netbox, loaded it, asked it to populate the PluginInfo structure
  • accessed the data in the structure and crashed, because it was rubbish.

Looking at the netbox code, the data is heap-allocated and should live at least till the next call of GetPluginInfo, so it is unlikely its fault.
Far doesn't call GetPluginInfo twice during this operation, so it is unlikely its fault either.
The only way to prematurely invalidate the data is another GetPluginInfo call by another plugin from another thread.

So... as usual: remove 3rdparty plugins and see how it goes.

P.S. I see Renewal in the plugins list and also a working thread spawned by it.
As far as I remember, it does call some APIs to get plugins versions from a background thread and it did cause similar issues in the past, so I'd start from it. If that's the case, turning off automatic checks in its settings and updating manually might help.

@MKadaner
Copy link
Contributor

Meh. Sometimes a memory dump is way better than any user stories.

I tend to agree with R Kh that this bug report could be improved. Something on the lines of "Crash" instead of "Bug report" in the issue title would not hurt. "I pressed enter on a png file," in the "Steps to reproduce" does not require huge effort either.

Even if this extra information would not help with analysis, somebody else with a similar issue might have worked out the solution on his own.

@LuckyTil
Copy link
Author

This Issue lacks all key elements of a good bug report: a specific concise yet meaningful title, clear Steps to Reproduce, unambiguous Expected and Actual behavior. These should not be buried in numerous attached archives without a very solid reason (and the reason, if any, has to be explained).
I suggest that this issue is either reworked fundamentally or rejected right away.

No. This was issue created in strict accordance with the instructions:
"Please send bug_report.txt and far.mdmp to the developers:

https://github.com/FarGroup/FarManager/issues
..."

@MKadaner
Copy link
Contributor

This was issue created in strict accordance with the instructions:
"Please send bug_report.txt and far.mdmp to the developers:

Not exactly. The "New issue" page has the following message at the top:

Please make sure to search for existing issues, check the FAQ and reporting guidelines before filing a new one.

The last link is the most relevant in this case.

@LuckyTil
Copy link
Author

Not exactly. The "New issue" page has the following message at the top:

Instructions were obtained from the exception message issued by Far Manager.

@alabuzhev
Copy link
Contributor

Instructions were obtained from the exception message issued by Far Manager.

Fair enough. I've updated it.

Anyway, back to the topic.
As I mentioned earlier, the issue is likely due to a thirdparty plugin and there is nothing for us to fix here, so closing for now.

@alabuzhev alabuzhev closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
@alabuzhev alabuzhev added external and removed bug labels Jan 22, 2024
@w17
Copy link
Contributor

w17 commented Jan 22, 2024

Create bug report for Renewal here

@HamRusTal
Copy link
Contributor

I've updated it.

Wouldn't it be even better to remind a user to give the bug report a meaningful title mentioning “crash”?
Also, wouldn't it make sense to call the generated text file crash_report.txt rather than bug_report.txt?

@alabuzhev
Copy link
Contributor

@HamRusTal maybe. Please feel free to create a new issue and we can discuss it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants