Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set per-binding custom labels #494

Open
bkrein-vertex opened this issue Oct 10, 2024 · 0 comments
Open

Add ability to set per-binding custom labels #494

bkrein-vertex opened this issue Oct 10, 2024 · 0 comments
Labels
enhancement Adding additional functionality or improvements help wanted Extra attention is needed priority: could Future work depending on bandwidth and availability stale Marked as stale by stalebot triage This bug needs triage

Comments

@bkrein-vertex
Copy link

Is your feature request related to a problem? Please describe.
I would like to be able to filter groups of RoleBindings created by rbac-manager based on labels. While it is possible to define custom labels to be set on ALL generated RoleBindings there doesn't appear to be a way to define labels on specific RoleBindings.

Describe the solution you'd like
I think supporting an additional field in the rbacBindings list objects could provide this ability:

rbacBindings:
  - name: my-rolebinding
    labels: 
      custLabel1: foo
      custLabel2: bar
    roleBindings: 
      - ... 
    subjects: 
      - ...

To result in something like this:

apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
  name: my-rolebinding
  labels: 
    rbac-manager: reactiveops   # Default 
    custLabel1: foo             # Custom 
    custLabel2: bar             # Custom 
  ...
roleRef: 
  ...
subjects:
  ...
@bkrein-vertex bkrein-vertex added enhancement Adding additional functionality or improvements triage This bug needs triage labels Oct 10, 2024
@sudermanjr sudermanjr added help wanted Extra attention is needed priority: could Future work depending on bandwidth and availability labels Oct 14, 2024
@github-actions github-actions bot added the stale Marked as stale by stalebot label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding additional functionality or improvements help wanted Extra attention is needed priority: could Future work depending on bandwidth and availability stale Marked as stale by stalebot triage This bug needs triage
Projects
None yet
Development

No branches or pull requests

2 participants