Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update heapless and hash32 #19

Conversation

tarfu
Copy link
Contributor

@tarfu tarfu commented Nov 9, 2023

No description provided.

@MathiasKoch
Copy link
Member

Thanks!
Could you make the CI happy on the tests & linting?

@tarfu tarfu force-pushed the feature/async-borrowed-sockets branch from 52e2e36 to 42480da Compare November 9, 2023 12:15
@tarfu
Copy link
Contributor Author

tarfu commented Nov 9, 2023

I'm not really sure what it is about the linker errors in the Test.
Using it in, for example, ublox-cellular-rs it is just fine building.

If you got an idea, I'm all for suggestions.

@tarfu tarfu force-pushed the feature/async-borrowed-sockets branch from 0dca311 to 8e2d82f Compare November 9, 2023 17:08
@tarfu tarfu force-pushed the feature/async-borrowed-sockets branch from 8e2d82f to 63ce0ac Compare November 9, 2023 17:09
@tarfu
Copy link
Contributor Author

tarfu commented Nov 9, 2023

The commit fixes the linking issue but not the tests itself which fail. But they don't seem to be related to the changes

@tarfu
Copy link
Contributor Author

tarfu commented Nov 10, 2023

It doesn't after readding the optional defmt dependency the linking is again an issue but,
cargo test --no-default-features --features socket-udp,socket-tcp works.

@MathiasKoch
Copy link
Member

Fair enough. Should we maybe change the CI to run that as tests instead?

@tarfu
Copy link
Contributor Author

tarfu commented Nov 10, 2023

Yes, I think that's a sensible solution.

@MathiasKoch
Copy link
Member

I don't understand why these tests are suddenly failing ...

@tarfu tarfu force-pushed the feature/async-borrowed-sockets branch from d90bfd2 to 7bd8bb5 Compare November 10, 2023 14:31
@tarfu
Copy link
Contributor Author

tarfu commented Nov 10, 2023

I tried to fix the tests on a logic level, but please take a look if they are still what they supposed to be.

@MathiasKoch
Copy link
Member

Ahh, Yeah.. I now see that the issue was originally on me, as I never actually ran the tests on this WIP async branch.

What you have done here seems super reasonable! Thanks!

I am sorry!

@MathiasKoch MathiasKoch merged commit 02a595a into FactbirdHQ:feature/async-borrowed-sockets Nov 13, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants