-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update heapless and hash32 #19
update heapless and hash32 #19
Conversation
Thanks! |
52e2e36
to
42480da
Compare
I'm not really sure what it is about the linker errors in the Test. If you got an idea, I'm all for suggestions. |
0dca311
to
8e2d82f
Compare
8e2d82f
to
63ce0ac
Compare
The commit fixes the linking issue but not the tests itself which fail. But they don't seem to be related to the changes |
It doesn't after readding the optional defmt dependency the linking is again an issue but, |
Fair enough. Should we maybe change the CI to run that as tests instead? |
Yes, I think that's a sensible solution. |
I don't understand why these tests are suddenly failing ... |
d90bfd2
to
7bd8bb5
Compare
I tried to fix the tests on a logic level, but please take a look if they are still what they supposed to be. |
Ahh, Yeah.. I now see that the issue was originally on me, as I never actually ran the tests on this WIP async branch. What you have done here seems super reasonable! Thanks! I am sorry! |
02a595a
into
FactbirdHQ:feature/async-borrowed-sockets
No description provided.