Replace embedded-time with fugit #54 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use ublox-sockets that support fugit time crate.
`embedded-time` has some serious issues and moves too slowly and tries to do too much in single lib. Fugit is a time library that was built because some people were not happy to use embedded-time on embedded systems. Fugit only deals with time conversions and those conversions are done using const generics. So most of the stuff is happening during compilation. This is very light weight compared to embedded-time.
the same is used in rtic and it is more clear what it is
#53) * Make sure the embedded-nal implementations only makes use of error-types from ublox-sockets * Add embedded-hal-driver keyword to crates.io # Conflicts: # ublox-cellular/Cargo.toml # ublox-cellular/src/services/data/tcp_stack.rs # ublox-cellular/src/services/data/udp_stack.rs
From trait cannot be used here because Clock error is associated type
fugit is needed for implementing Clock trait therefore it makes sense to reexport it here
on macos dummy gpio support is used
without those it returns immediately without blocking in place
macOS creates those nasty files
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
==========================================
+ Coverage 10.00% 10.01% +0.01%
==========================================
Files 54 57 +3
Lines 1510 1547 +37
Branches 347 368 +21
==========================================
+ Hits 151 155 +4
- Misses 1329 1361 +32
- Partials 30 31 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overtakes #54 to fix failing CI.
See #54 for discussion on PR.
This rust-lang/cargo#10269 should allow us to rename "defmt-impl" to "defmt" again, once it is in stable