Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work Minecraft 1.16.1 with LWJGW 3.3.2 #1170

Open
naari3 opened this issue Sep 11, 2024 · 11 comments
Open

Does not work Minecraft 1.16.1 with LWJGW 3.3.2 #1170

naari3 opened this issue Sep 11, 2024 · 11 comments
Labels
Milestone

Comments

@naari3
Copy link

naari3 commented Sep 11, 2024

I downloaded the 1.16.1 template and tried to launch the client from the launch configuration generated by .\gradlew vscode, but it crashed with the following log:

https://mclo.gs/T3fg5gE

What I found interesting here was that the LWJGL version was 3.3.2 even though the log was for 1.16.1.

If I understand correctly, Minecraft 1.16.1 uses LWJGL 3.2.1 or 3.2.2, and the error in this log seems to be caused by a difference in the version of LWJGL.

ref: https://piston-meta.mojang.com/v1/packages/54fa3af57d041d2771e66d390197b2c0288e697c/1.16.1.json

I created an issue because I don't know how the LWJGL-related libraries under .gradle/loom-cache/natives/1.16.1/windows are downloaded and deployed here, and I would like to know if there is a way to change this version.

@modmuss50
Copy link
Member

Loom upgrades LWJGL when required, e.g to support a newer version of Java or to support a platform such as ARM64 MacOS that was previously unsupported.

The rules for this are located here: https://github.com/FabricMC/fabric-loom/blob/dev/1.7/src/main/java/net/fabricmc/loom/configuration/providers/minecraft/library/processors/LWJGL3UpgradeLibraryProcessor.java#L53-L60

Disabling it would just lead to a crash at runtime anyway. You still compile against the older version so your mod should remain compatible.

The fact that its causing a crash becuase it was upgraded isnt ideal at all, and something that I should look into. Maybe try using Java 17?

@naari3
Copy link
Author

naari3 commented Sep 11, 2024

The fact that its causing a crash becuase it was upgraded isnt ideal at all, and something that I should look into. Maybe try using Java 17?

Does this mean that 1.16.1 with LWJGW 3.3.2 should work? I'm not familiar with interacting with LWJGL and would love to hear about this. thanks.

@modmuss50
Copy link
Member

Yes, I expected this to work, and it does for most versions of the game. I think this version went untested and this issue wasnt noticed. I am confident I can find a solution that will enable you to use Java 21+ on 1.16.1, for now just stick to Java 17.

@modmuss50 modmuss50 added the bug label Sep 11, 2024
@modmuss50 modmuss50 added this to the 1.8 milestone Sep 11, 2024
@naari3
Copy link
Author

naari3 commented Sep 11, 2024

Just to be clear, I tested it with Java 17 and it worked fine (works on LWJGW 3.2.2).

@naari3 naari3 changed the title Why does fabric-loom try to use lwjgl 3.3.2 even though it's for Minecraft 1.16.1? Does not work Minecraft 1.16.1 with LWJGW 3.3.2 Sep 11, 2024
@naari3
Copy link
Author

naari3 commented Sep 11, 2024

I changed the title, but if you find something better please change it to that. 🙏

@modmuss50
Copy link
Member

Hi, I am unable to reproduce this crash, im using Java 21 and Minecraft 1.16.1, can you post the full startup log including mod list please?

@naari3
Copy link
Author

naari3 commented Sep 27, 2024

Here it is. Is this enough? If there is anything missing, please let me know and I will take care of it.
https://mclo.gs/qBUnDFS

@modmuss50
Copy link
Member

Yes, thanks thats helpful. I see you are on Windows I wonder if that has something to do with it, I will test this myself on Windows.

@modmuss50
Copy link
Member

On windows it still seems to work for me, at least when I run gradlew.bat runClient, and via intelij. I wonder if this is a VSCode issue?

Could you possibly try this command to see if it works, if not gradlew.bat runClient --refresh-dependencies.

@naari3
Copy link
Author

naari3 commented Sep 29, 2024

Oh sorry, I forgot to mention in the issue that it was the VSCode Launch Target that failed this time!

I ran runClient task from the console and it started without any issues! so this looks like a launch.json or vscode issue?.

and, I also tested launch target Minecraft Client with a clean profile with only the extensions we needed installed but it still doesn't work. (this is not a exactly clean environment, but It takes too much time to setup a clean vscode on my computer sorry)

@modmuss50 modmuss50 modified the milestones: 1.8, 1.9 Oct 10, 2024
@modmuss50
Copy link
Member

I dont think there is a lot we can do about this sadly. I believe this is a limiation of vscode and eclipse. The workaround is to use the gradle run tasks or Intelij.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants