-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow interface Mixins #51
Conversation
Reapplies FabricMC#13 Fixes FabricMC#34 Includes (a form of) SpongePowered#413 and SpongePowered#415
Whilst SpongePowered#415 is generating things more correctly, there are mods (such as Better End) which rely on the current behaviour
Will this allow people to inject into things like Inventory and run code every time, for example, getStack or something gets called? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me
No, this is strictly for Mixining into the interface itself. With |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite an essential PR that I hope to see merged soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reimplements #13 more expansively, allows things like...