Filtering option #28
Filtering option #28
Conversation
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "stage": 0 | |||
| "presets": ["stage-0"] | |||
There was a problem hiding this comment.
Currently babel 5.x is used, not sure this change is appropriate.
There was a problem hiding this comment.
Sorry, I’m not that experienced, so I failed to compile it to js. I just installed babel-cli latest version and ran ‘npm publish’. Could you explain how to compile it? I’ll reverse these changes.
There was a problem hiding this comment.
You don't need to use babel-cli or npm publish (this one is for publisher).
You don't need to compile to run test.
Just do "npm install" (you probably already did), and then "npm test". This will run test (lint + automated tests).
To see what happen under the hood, just type "npm run" and you should understand a bit what is happening.
Feel free to ask for more if you need.
|
Can you add tests for this change? |
|
Any change you clean this PR, remove dist files and add test? |
|
Hi! Sorry, I’ve completely forgotten. Too busy at work atm. ———
|
|
Hi! Sorry again, I’ve tried to cover my changes with tests, but I’m not sure I can do that. I’ve never done that before. Maybe, you can point to some resources and give a rough idea where to start? What your test does and how to run it? |
Allows to pass multimatch filter to remove unwanted files from livereload update message