Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Direwolf20 v1.5.0 to curseforge #6312

Closed
FelixHe opened this issue Dec 2, 2024 · 7 comments
Closed

Add Direwolf20 v1.5.0 to curseforge #6312

FelixHe opened this issue Dec 2, 2024 · 7 comments
Labels
Enhancement General suggestion or improvement. FTB Presents Direwolf20 1.21 @Replied Author has replied to the issue

Comments

@FelixHe
Copy link

FelixHe commented Dec 2, 2024

Modpack

FTB Presents Direwolf20 1.21

Is your suggestion related to a problem? Please describe.

Currently I'm using docker to deploy the newest version of the modpacks. The newest version of the direwolf20 pack is 1.5.0 now but that version is only deployed to FTB currently and not to curseforge. The docker image I'm using uses the following API to retrieve the versions: https://api.modpacks.ch/public/modpack/126

Thanks for your help in advance!

Mod suggestion

No response

@FelixHe FelixHe added the Enhancement General suggestion or improvement. label Dec 2, 2024
@framerunner
Copy link

framerunner commented Dec 2, 2024

I've had the same issue, despite pulling from FTB and not curse.
(I'm using itzg/minecraft-server to be more specific)
For now you can add "FTB_MODPACK_VERSION_ID" to your Env and set it to "100001" so it's forced to pull the 1.5.0 version
(Douplicate/Edit your container)
Make sure that "TYPE" is set to "FTBA", so you pull from FTB.

Edit: Nice in theory, doesn't work though.
It just loads forever, so it seems it's a different issue, if we can't even pull the latest from FTB.
That leaves us to downgrade our clients for nowor upgrade manually.

@FelixHe
Copy link
Author

FelixHe commented Dec 3, 2024

Yes, exactly. The startup log states: "Error fetching modpack: version does not exist" if I put the FTB_MODPACK_VERSION_ID 100001 in it.

@Gaz492
Copy link
Member

Gaz492 commented Dec 3, 2024

We are working on getting the modpack uploaded to curseforge, we just need to update a few mods and wait for the version to be approved.

As for the issue you are having with your docker image, our API has changed, as an example the API url for DW20 1.21 is now https://api.feed-the-beast.com/v1/modpacks/public/modpack/126

@github-actions github-actions bot added the state: Awaiting Reply A reply is awaited from a user. label Dec 3, 2024
@FelixHe
Copy link
Author

FelixHe commented Dec 4, 2024

Hi!
The docker image author (itzg/docker-minecraft-server) changed the API to use the new one you mentioned. Now it correctly gets the new version but when it tries to start the ftbinstaller with the newer modpack version ID it fails again with the message:
"ERROR fetching modpack: version does not exist"

What I could see is that the script tries to execute the following command on the shell:
ftb-installer "126" "100001" --noscript --auto > ftb-installer.log

That should be correct shouldn't it?

@github-actions github-actions bot added @Replied Author has replied to the issue and removed state: Awaiting Reply A reply is awaited from a user. labels Dec 4, 2024
@Gaz492
Copy link
Member

Gaz492 commented Dec 4, 2024

Ahh, they will also need to change some parameters on the server installer command as we also released a new version which changes it a bit.

I don't know if you can change the command or if the maintainer of the docker image needs to (i'm not familiar with that docker image).

The new command to run the installer would be ftb-installer -pack "MODPACK_ID" -version "MODPACK_VERSION" -auto -force
-no-script is no longer an option as it just modifies the standard forge/neoforge scripts that gets generated
-force is a new flag that just tells the installer to ignore any warnings that may require user input when using -auto

Usage of ./installer_125:
  -auto
        Dont ask questions, just install the server
  -dir string
        Installation directory
  -force
        Force the modpack install (only works with -auto)
  -latest
        Gets the latest version of the modpack
  -no-colours
        Do not use colours
  -no-java
        Do not install Java
  -pack int
        Modpack ID
  -provider string
        Modpack provider (Currently only 'ftb' is supported) (default "ftb")
  -skip-modloader
        Skip installing the modloader
  -threads int
        Number of threads to use (Default: CPU Cores * 2) (default 20)
  -validate
        Validate the modpack after install
  -verbose
        Verbose output
  -version int
        Modpack version ID, if not provided, the latest version will be used

@github-actions github-actions bot added state: Awaiting Reply A reply is awaited from a user. and removed @Replied Author has replied to the issue labels Dec 4, 2024
@FelixHe
Copy link
Author

FelixHe commented Dec 4, 2024

Thanks for your very quick reply!
I forwarded this issue and your comment to the author of the docker image and hope he could implement the new parameters.

Thanks!

@github-actions github-actions bot added @Replied Author has replied to the issue and removed state: Awaiting Reply A reply is awaited from a user. labels Dec 4, 2024
@ArtpokeBr
Copy link
Collaborator

This seems to have been fixed, so I'am going to close the issue =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement General suggestion or improvement. FTB Presents Direwolf20 1.21 @Replied Author has replied to the issue
Projects
None yet
Development

No branches or pull requests

4 participants