Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shipped systemd unit uses deprecated path in PIDFile #17032

Open
2 tasks done
SRv6d opened this issue Oct 8, 2024 · 2 comments · May be fixed by #17404
Open
2 tasks done

Shipped systemd unit uses deprecated path in PIDFile #17032

SRv6d opened this issue Oct 8, 2024 · 2 comments · May be fixed by #17404
Assignees
@Jafaral
Labels
triage Needs further investigation

Comments

@SRv6d
Copy link

SRv6d commented Oct 8, 2024

Description

The systemd unit file shipped with FRRouting uses a deprecated path in it's PIDFile directive, causing systemd to to log the following error:

/usr/lib/systemd/system/frr.service:20: PIDFile= references a path below legacy directory /var/run/, updating /var/run/frr/watchfrr.pid → /run/frr/watchfrr.pid; please update the unit file accordingly.

Version

FRRouting 10.1.1 on Linux(5.14.0-427.18.1.el9_4.x86_64).
Copyright 1996-2005 Kunihiro Ishiguro, et al.
configured with:
    '--build=x86_64-redhat-linux-gnu' '--host=x86_64-redhat-linux-gnu' '--program-prefix=' '--disable-dependency-tracking' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib64' '--libexecdir=/usr/libexec' '--sharedstatedir=/var/lib' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--sbindir=/usr/lib/frr' '--sysconfdir=/etc' '--localstatedir=/var' '--disable-static' '--disable-werror' '--enable-multipath=256' '--enable-vtysh' '--enable-ospfclient' '--enable-ospfapi' '--enable-rtadv' '--enable-ldpd' '--enable-pimd' '--enable-pim6d' '--enable-pbrd' '--enable-nhrpd' '--enable-eigrpd' '--enable-babeld' '--enable-vrrpd' '--enable-user=frr' '--enable-group=frr' '--enable-vty-group=frrvty' '--enable-fpm' '--enable-watchfrr' '--disable-bgp-vnc' '--enable-isisd' '--enable-rpki' '--enable-bfdd' '--enable-pathd' '--enable-snmp' 'build_alias=x86_64-redhat-linux-gnu' 'host_alias=x86_64-redhat-linux-gnu' 'PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' 'CC=gcc' 'CXX=g++' 'LT_SYS_LIBRARY_PATH=/usr/lib64:'

How to reproduce

Install FRRouting from the provided repos.

Expected behavior

Don't use deprecated paths.

Actual behavior

systemd error:

/usr/lib/systemd/system/frr.service:20: PIDFile= references a path below legacy directory /var/run/, updating /var/run/frr/watchfrr.pid → /run/frr/watchfrr.pid; please update the unit file accordingly.

Additional context

No response

Checklist

  • I have searched the open issues for this bug.
  • I have not included sensitive information in this report.
@SRv6d SRv6d added the triage Needs further investigation label Oct 8, 2024
@vayetze vayetze assigned vayetze and Jafaral and unassigned vayetze Oct 8, 2024
@donaldsharp
Copy link
Member

The path generated is selected by the operators configure statement, here's our line in the frr.service:
PIDFile=@e_frr_runstatedir@/watchfrr.pid

This is generated from the configure.ac option of --local-state-dir=XXX.

Since I have absolutely no idea where you got your frr packaging I cannot comment on whether or not how it got a localstatedir = /var setting

@SRv6d
Copy link
Author

SRv6d commented Oct 9, 2024

Like mentioned in the issue, FRR is installed from the provided repositories, specifically https://rpm.frrouting.org/repo/frr-stable-repo-1-0.el8.noarch.rpm on Rocky Linux 9.4, the same goes for the Debian stable repositories though.

I made a cursory attempt at finding where that setting is defined but I only found some comments indicating what it is set to.

tools/frrcommon.sh.in
26:V_PATH="@e_frr_runstatedir@${suffix}" # /var/run/frr

tools/frr.in
19:V_PATH="@e_frr_runstatedir@" # /var/run/frr

@ton31337 ton31337 linked a pull request Nov 11, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jafaral Jafaral

Labels
triage Needs further investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

packaging: Specify /run as a runstatedir opensourcerouting/frr
4 participants
@donaldsharp @Jafaral @SRv6d @vayetze