Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the team_key field in an org with JUST team_keys #236

Open
JL102 opened this issue Apr 3, 2024 · 0 comments
Open

Replace the team_key field in an org with JUST team_keys #236

JL102 opened this issue Apr 3, 2024 · 0 comments
Labels
code organization / reduce tech debt Complexity - 3 Large Issue estimated to require a significant amount of dev effort, potentially broken into sub-issues. Importance - 1 Low A low-impact issue, e.g. visual improvement or nice-to-have feature.

Comments

@JL102
Copy link
Collaborator

JL102 commented Apr 3, 2024

It's a pain in the butt to have two fields, team_key and team_keys, and checking for the existence of either in every spot where it's necessary. The code would be much simpler to just have team_keys, and require that the array have a length of at least 1.
@JL102 JL102 added Complexity - 3 Large Issue estimated to require a significant amount of dev effort, potentially broken into sub-issues. Importance - 1 Low A low-impact issue, e.g. visual improvement or nice-to-have feature. code organization / reduce tech debt labels Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code organization / reduce tech debt Complexity - 3 Large Issue estimated to require a significant amount of dev effort, potentially broken into sub-issues. Importance - 1 Low A low-impact issue, e.g. visual improvement or nice-to-have feature.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JL102