-
-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure features are found/not found in our comprehensive builds #3336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jørgen Schartum Dokken <[email protected]>
… jhale/add-has-scotch
support, then exit.
… jhale/add-has-scotch
jhale
changed the title
Make sure features are being actually found in our kitchen sink build.
Ensure features are found/not found in our comprehensive builds
Aug 7, 2024
This PR mixes some unrelated changes - can it be simplified to just include the CMake CI changes? |
Yes - I will tidy and merge #3335 first and then rebase this on top. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that KAHIP wasn't being found. This PR enables explicit dependency checks on our kitchen sink build to catch silent mistakes. KAHIP issue still needs fixing.
Also includes #3335.