Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark IndexMaps on communicators with size 1 as non-overlapped #3066

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

garth-wells
Copy link
Member

For Functions on an MPI communicator of size 1, this change reduced the number of communicators that are created.

@garth-wells garth-wells added the enhancement New feature or request label Feb 24, 2024
@chrisrichardson
Copy link
Contributor

Can we get rid of _overlapping and just store the comm size (or ask MPI for it)? I don't think we ever use an IndexMap with no overlap, except when in serial. At least, the constructor IndexMap(comm, local_size) doesn't seem to be used internally.

@garth-wells garth-wells added this pull request to the merge queue Mar 2, 2024
Merged via the queue into main with commit 77729e5 Mar 2, 2024
19 checks passed
@garth-wells garth-wells deleted the garth/index-map-overlap branch March 2, 2024 15:26
@jorgensd
Copy link
Member

jorgensd commented Mar 2, 2024

Can we get rid of _overlapping and just store the comm size (or ask MPI for it)? I don't think we ever use an IndexMap with no overlap, except when in serial. At least, the constructor IndexMap(comm, local_size) doesn't seem to be used internally.

I use that indexmap ( IndexMap(comm, local_size)) in some of my codes. I guess I can adapt it to sending in no ghosts.

@garth-wells
Copy link
Member Author

I use that indexmap ( IndexMap(comm, local_size)) in some of my codes. I guess I can adapt it to sending in no ghosts.

It’s used in a few tests too, so I think we should keep the constructor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants