Fix input arguments to dolfinx.mesh.refine_plaza
#3018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported at https://fenicsproject.discourse.group/t/input-for-mesh-refinement-with-refine-plaza/13426
It seems to me that the current python API is certainly wrong (the
option
argument is not used anywhere), but I can't understand how it is possible that tests onmain
are currently passing since:nanobind
wrapped function is not being passed in from python, butnanobind
is not complaining.refine_plaza
were providing input arguments in the wrong order.Opening this as draft because I have no experience with mesh refinement, so I'd need help from someone else if the fix is more involved than sorting out wrong order of input arguments.