Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some implicit PETSc from tests when not needed #2970

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

chrisrichardson
Copy link
Contributor

Change use of .vector to .x.array which removes a PETSc dependency for these tests.

@chrisrichardson chrisrichardson marked this pull request as ready for review January 8, 2024 11:41
@garth-wells garth-wells added this pull request to the merge queue Jan 8, 2024
@chrisrichardson
Copy link
Contributor Author

Just found another one... oh well, will make another PR.

@francesco-ballarin
Copy link
Member

@chrisrichardson in my web interface there is a button "Remove from queue" if you wish to stop the merge, add the commit and then add the PR back to the merge queue afterwards

@chrisrichardson chrisrichardson removed this pull request from the merge queue due to a manual request Jan 8, 2024
@chrisrichardson chrisrichardson added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit 90b47de Jan 8, 2024
20 of 36 checks passed
@chrisrichardson chrisrichardson deleted the chris/depetscify-some-tests branch January 8, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants