Wrap C++ Mesh from Python (fixes support for Python 3.11)
#2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garth-wells
added
bug
jorgensd
reviewed
Jan 6, 2023
jorgensd
reviewed
Jan 6, 2023
jorgensd
reviewed
Jan 6, 2023
|
PR is at draft stage. No need for detailed comments yet, plenty to fix up first. |
garth-wells
force-pushed
the
garth/py-mesh
branch
from
734d29d
to
a5de737
Compare
|
@jorgensd, @francesco-ballarin PR is ready now if you have more comments. |
garth-wells
changed the title
Mesh from PythonMesh from Python (fixes support for Python 3.11)
jorgensd
approved these changes
Jan 28, 2023
| @@ -330,7 +330,7 @@ def test_facet_h(ct): | |||
| N = 3 | |||
| mesh = create_unit_cube(MPI.COMM_WORLD, N, N, N, ct) | |||
| left_facets = locate_entities_boundary(mesh, mesh.topology.dim - 1, lambda x: np.isclose(x[0], 0)) | |||
| h = _cpp.mesh.h(mesh, mesh.topology.dim - 1, left_facets) | |||
| h = _cpp.mesh.h(mesh._cpp_object, mesh.topology.dim - 1, left_facets) | |||
There was a problem hiding this comment.
Maybe we should make a Pythonwrapper for cpp.mesh.h?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between C++ and Python meshes is that Python meshes have
ufl_cellandufl_domainmethods. The 'trick' used to handle mesh construction does not work with Python 3.11 (see #2423 (comment)).This change wraps all
Meshinstances in Python. This change is simple and fixes #2423, and will allow straightforward future support of different precision mesh geometry storage. It does, however, involve more hand-coding of methods and functions that operate of meshes. The design is similar to howFunctionSpaceis handled on the Python side. The upside of the extra hand-coding is that docstring are easier to write.