Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check of element hash #3169

Closed
mscroggs opened this issue Apr 25, 2024 · 0 comments · Fixed by #3186
Closed

Add check of element hash #3169

mscroggs opened this issue Apr 25, 2024 · 0 comments · Fixed by #3186
Labels
enhancement New feature or request
Milestone

Comments

@mscroggs
Copy link
Member

Describe new/missing feature

After #3136, we reuse Basix elements rather than recreating them based on information from UFCx.

In FEniCS/ffcx#681, a hash of the element is added to the generated code. We should add a check (here:

// TODO: Hash check of element
) that confirms that the hash of the element being used matches that in the generated code.

Suggested user interface

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants