Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scaling cyclecounter dynamically #4026

Closed
Sonicadvance1 opened this issue Sep 3, 2024 · 0 comments · Fixed by #4033
Closed

Support scaling cyclecounter dynamically #4026

Sonicadvance1 opened this issue Sep 3, 2024 · 0 comments · Fixed by #4033

Comments

@Sonicadvance1
Copy link
Member

Today FEX hardcodes a left shift of 7 for any cycle counter that is below 1Ghz. This was mostly done out of laziness because it covered all platforms I cared about at the time, and ARMv8.6/ARMv9.1 mandates a 1Ghz cycle counter to be compliant.

We should instead dynamically scale the cycle counter since there are platforms that have a higher frequency counter. Which apparently causes issues with libpsm2? We are still likely to typically hit scale factor of 7 or 6, so it won't change dramatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant