Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dash symbol in network codes? #14

Open
flofux opened this issue Jul 9, 2020 · 7 comments
Open

Dash symbol in network codes? #14

flofux opened this issue Jul 9, 2020 · 7 comments

Comments

@flofux
Copy link

flofux commented Jul 9, 2020

Is there any reason to not allow the dash symbol in network codes? I imagine it could create some confusion if people can use it for station and location, but not for network ...

It could also be nicely used to separate the year from the (old) network name: 6A-2019

@crotwell
Copy link

crotwell commented Jul 9, 2020

My only objections would be it is a wasted byte and makes it a little harder to parse as there is an extra deliminator in the mix. Not sure either of those are very strong reasons given we allow it in station and location codes.

I do think that we should strongly pin down the way that existing 2-char temporary networks are mapped to longer network codes. The one thing that we should avoid at all costs is some old temporary networks using XA2014 and others using XA-2014. i care much more about that being consistent than about how it is done.

@crotwell
Copy link

crotwell commented Jul 9, 2020

related #9

@crotwell
Copy link

Two other thoughts. If dash is allowed now, but its use is not specified, then we lose the ability to make it mean something later. I don't think that there is a reason delimiting network codes would be useful in the future, but who knows.

Second, if dash is allowed, it should not be the first or last character. So -9-SEIS- should not be valid.

Lastly, adding a char here probably should come with a good reason. The separation between 2 chars and the start year doesn't seem that strong, since it has to be exactly 2 chars followed by 4 numbers. Without a compelling reason to add it into the mix (as exists with station codes and location codes within arrays of stations or grids of location at a station) I probably would lean against allowing dash at this point.

@chad-earthscope
Copy link
Member

I do not feel very strongly one way or the other. The station and location fields could use a dash for an organizing scheme within a network. I couldn't come up a good reason to add it to network other than "for consistency" and so left it out for simplicity.

@flofux
Copy link
Author

flofux commented Jul 16, 2020

I just wanted to bring this up ;-) It's totally OK if we don't allow the dash for networks. If you already have some doubts about it, it's enough of a reason to not do it guess.

@chad-earthscope
Copy link
Member

Heh. This is exactly the kind of question others will bring up when this gets to a larger audience so it's good to consider and record some reasoning, so thanks for raising it!

@WayneCrawford
Copy link

I do agree that a new delimiter shouldn't be brought in unless necessary...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants