Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move 'awsCredentialsFile' into nested structure and add to validation schema #1468

Open
shnizzedy opened this issue Mar 19, 2021 · 0 comments
Open

Move 'awsCredentialsFile' into nested structure and add to validation schema #1468

shnizzedy opened this issue Mar 19, 2021 · 0 comments
Labels
improvement

Comments

@shnizzedy
Copy link
Member

This caught my eye when working on #1437:

C-PAC/dev/docker_data/run.py

Line 486 in 1cbbdaf

c['awsCredentialsFile'] = resolve_aws_credential(args.aws_input_creds)

I suppose we should sometime update these kinds of runtime configurations (not in the config file) to

  • fit into the nested structure (like this one I'd think would end up being something like ['pipeline_setup']['Amazon-AWS']['aws_input_bucket_credentials']
  • validate the keys/values

Originally posted by @shnizzedy in #1438
@sgiavasis sgiavasis added this to the 1.8.1 Release milestone Mar 19, 2021
@shnizzedy shnizzedy added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Sep 30, 2021
@shnizzedy shnizzedy removed this from the 1.8.2 Release milestone Feb 10, 2022
@shnizzedy shnizzedy removed the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgiavasis @shnizzedy