Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modification: Clinical Chemistry to be removed as a direct child of Chemistry #77

Closed
allysonlister opened this issue Oct 9, 2023 · 1 comment
Assignees
Milestone

Comments

@allysonlister
Copy link
Collaborator

What are you changing?

Placement of http://purl.obolibrary.org/obo/NCIT_C16417 within SRAO.

Clinical Chemistry is a child of Analytical Chemistry, Chemistry, Health Science and Medicine.

However, as Analytical Chemistry is a direct child of Chemistry, it makes no sense to keep Clinical Chemistry as a child of both. Therefore we will keep it only as a child of Analytical Chemistry.

Why are you suggesting this change?

The new build procedure has built-in reasoning and noticed this issue. Will be cleaner this way.

Hierarchy

Recommendation: Remove Chemistry as a direct parent of Clinical Chemistry

Reasoning: Unnecessary placement under both Analytical Chemistry and Chemistry.

@allysonlister allysonlister added this to the Release 0.4.0 milestone Oct 9, 2023
@allysonlister allysonlister self-assigned this Oct 9, 2023
allysonlister added a commit that referenced this issue Oct 10, 2023
@allysonlister
Copy link
Collaborator Author

This is now complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant