Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom data in game.prefs breaking Notify management window #6044

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

lL1l1
Copy link
Contributor

@lL1l1 lL1l1 commented Apr 3, 2024

Description of the proposed changes

Fixes a Discord bug report (Notify menu missing Seraphim T4) by adding a nil check.

Cause:

Nomads makes Notify save the following data in game.prefs:

Notify_Messages_ESC = {
  ...
  experimentals = {
    ...
    xnl0401 = '\\u41\\u74\\u6C\\u61\\u73',
    xna0403 = '\\u43\\u72\\u61\\u77\\u6C\\u65\\u72',
    xnl0402 = '\\u42\\u65\\u61\\u6D\\u65\\u72',
  },
  ...
},

When back in FA, Notify fails to create the setting lines past the Novax line for the experimentals tab in the "Notify Management" window because it fails to find an alias for the Nomads blueprint ids from ClarityTable. This could be solved by adding the data to the defaultmessages.lua file (Nomads does), but then the Nomads experimentals would appear as options despite the units not being in the current session, so I opted for a nil check instead.

Testing done on the proposed changes

Add the data into my game.prefs, and go to the in-game menu -> Notify Management -> Experimentals window. All the FA experimentals display correctly and you can scroll down if you open more tabs.

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@Garanas Garanas added the area: ui Anything to do with the User Interface of the Game label Apr 3, 2024
@Garanas
Copy link
Member

Garanas commented Apr 3, 2024

Great find and fix 👍

@Garanas Garanas merged commit 140f650 into FAForever:deploy/fafdevelop Apr 3, 2024
@lL1l1 lL1l1 deleted the Fix/notify-nomads-compat branch May 24, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Anything to do with the User Interface of the Game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants